From sunfreeware at gmail.com Mon Mar 24 02:19:55 2008 From: sunfreeware at gmail.com (Steven M. Christensen) Date: Mon, 24 Mar 2008 05:19:55 -0400 Subject: [companion-integrate] RTI - Minor fix to xmms build Message-ID: <47E7723B.7040400@gmail.com> This is a RTI for a minor fix to the build of the xmms package. The configure step is now finding a fts.h file in recent versions of Nevada and this breaks the build. The patch here removes the problem and a nightly in NV 84 for SPARC and x86 now works with no problem. http://companion.sunfreeware.com/downloads/xmmswebrev/ This has been reviewed by Paul Cunningham. See companion-discuss. His suggested alternatives to this fix would not work and so this original change has been kept. I am still open to some other method if it can be made to work. Steve Christensen From Mike.Sullivan at sun.com Mon Mar 24 12:36:58 2008 From: Mike.Sullivan at sun.com (Mike Sullivan) Date: Mon, 24 Mar 2008 12:36:58 -0700 Subject: [companion-integrate] RTI - Minor fix to xmms build In-Reply-To: <47E7723B.7040400@gmail.com> References: <47E7723B.7040400@gmail.com> Message-ID: <47E802DA.20200@Sun.COM> Steven M. Christensen wrote: > This is a RTI for a minor fix to the build of the xmms package. > The configure step is now finding a fts.h file in recent versions of > Nevada and this breaks the build. The patch here removes the problem > and a nightly in NV 84 for SPARC and x86 now works with no problem. > > http://companion.sunfreeware.com/downloads/xmmswebrev/ > > This has been reviewed by Paul Cunningham. See companion-discuss. > His suggested alternatives to this fix would not work and so > this original change has been kept. I am still open to > some other method if it can be made to work. So I have two concerns: 1. I don't think I like this being called 'patch'. That's very generic, it would seem better to have a more descriptive name (or put it in the other patch, but I think I like separating patches for different things). So maybe patch.removeftw_h? 2. It almost feels like there should be a comment describing what we are doing and why here (since we have no bug database yet that could be referred to). Though I'm open to the argument that it's obvious - but it still might be nice to identify the build ftw.h appeared in maybe. I'm flexible on #2, but if you at least fix #1 then then I approve :) Mike From danek.duvall at sun.com Mon Mar 24 12:59:42 2008 From: danek.duvall at sun.com (Danek Duvall) Date: Mon, 24 Mar 2008 12:59:42 -0700 Subject: [companion-integrate] RTI - Minor fix to xmms build In-Reply-To: <47E802DA.20200@Sun.COM> References: <47E7723B.7040400@gmail.com> <47E802DA.20200@Sun.COM> Message-ID: <20080324195942.GS29238@zruty.sfbay.sun.com> On Mon, Mar 24, 2008 at 12:36:58PM -0700, Mike Sullivan wrote: > 2. It almost feels like there should be a comment describing what > we are doing and why here (since we have no bug database yet > that could be referred to). Feel free to use defect.opensolaris.org if you feel it's appropriate. I can add categories (product and components, in bugzilla lingo) since you'll probably need new ones. Danek From sunfreeware at gmail.com Tue Mar 25 01:36:02 2008 From: sunfreeware at gmail.com (Steven M. Christensen) Date: Tue, 25 Mar 2008 04:36:02 -0400 Subject: [companion-integrate] RTI - Minor fix to xmms build In-Reply-To: <47E802DA.20200@Sun.COM> References: <47E7723B.7040400@gmail.com> <47E802DA.20200@Sun.COM> Message-ID: <47E8B972.1060301@gmail.com> Mike - I have redone the patch and Makefile.sfw as you suggest. See http://companion.sunfreeware.com/downloads/xmmswebrev/ As far as I can see, here is where fts.h appeared 4887 17-Aug-2007 chin 6437624 RFE: Add ksh93 (as /usr/bin/ksh93) and libshell.so to OS/Net 6505835 AST tools and library (libpp) required for creating l10n messages for ksh93 PSARC/2006/550 Korn Shell 93 Integration PSARC/2006/587 /etc/ksh.kshrc for ksh93 PSARC/2007/035 ksh93 Amendments Contributed by Roland Mainz Steven M. Christensen wrote: >> This is a RTI for a minor fix to the build of the xmms package. >> The configure step is now finding a fts.h file in recent versions of >> Nevada and this breaks the build. The patch here removes the problem >> and a nightly in NV 84 for SPARC and x86 now works with no problem. >> >> http://companion.sunfreeware.com/downloads/xmmswebrev/ >> >> This has been reviewed by Paul Cunningham. See companion-discuss. >> His suggested alternatives to this fix would not work and so >> this original change has been kept. I am still open to >> some other method if it can be made to work. > > So I have two concerns: > > 1. I don't think I like this being called 'patch'. That's very > generic, it would seem better to have a more descriptive name > (or put it in the other patch, but I think I like separating patches > for different things). So maybe patch.removeftw_h? > > 2. It almost feels like there should be a comment describing what > we are doing and why here (since we have no bug database yet > that could be referred to). Though I'm open to the argument that > it's obvious - but it still might be nice to identify the build > ftw.h appeared in maybe. > > I'm flexible on #2, but if you at least fix #1 then then I approve :) > > Mike > From Mike.Sullivan at sun.com Wed Mar 26 13:03:25 2008 From: Mike.Sullivan at sun.com (Mike Sullivan) Date: Wed, 26 Mar 2008 13:03:25 -0700 Subject: [companion-integrate] RTI - Minor fix to xmms build In-Reply-To: <47E8B972.1060301@gmail.com> References: <47E7723B.7040400@gmail.com> <47E802DA.20200@Sun.COM> <47E8B972.1060301@gmail.com> Message-ID: <47EAAC0D.4060000@Sun.COM> Steven M. Christensen wrote: > Mike - > > I have redone the patch and Makefile.sfw as you suggest. See > > http://companion.sunfreeware.com/downloads/xmmswebrev/ ok fine. > > As far as I can see, here is where fts.h appeared > > > > 4887 17-Aug-2007 chin 6437624 RFE: Add ksh93 (as > /usr/bin/ksh93) and libshell.so to OS/Net > 6505835 AST tools and library (libpp) required for creating l10n > messages for ksh93 > PSARC/2006/550 Korn Shell 93 Integration > PSARC/2006/587 /etc/ksh.kshrc for ksh93 > PSARC/2007/035 ksh93 Amendments > Contributed by Roland Mainz > > > fts.h is in /usr/include/ast and elsewhere. It is in 81 > and perhaps in slightly earlier versions. If that's where it first appeared, then it would be build 72. But that's indeed in /usr/include/ast - is that really the one that xmms picks up? It knows about ksh93's include directory? I guess it must be as it's the only one I see in 85: {mike_s:yavin:435} grep fts.h */pkgmap | grep include SUNWhea/pkgmap:1 f none usr/include/ast/fts.h 0644 root bin 5774 5390 1204921034 it's kinda weird to just find that now though, since I know we've both built the ccd since ksh93 integrated. > > If the above fix is OK I will do the commit. If this is appropriate for > a bug report, I can do that as well if there is a good place for it. Well actually, now I'm a little worried. Why is xmms only finding this now? It showed up in august, but my last ccd build was in january, and I had that header. And I'm up to date with the ccd workspace. So what is really going on? ack. Mike From sunfreeware at gmail.com Wed Mar 26 14:05:54 2008 From: sunfreeware at gmail.com (Steven M. Christensen) Date: Wed, 26 Mar 2008 17:05:54 -0400 Subject: [companion-integrate] RTI - Minor fix to xmms build In-Reply-To: <47EAAC0D.4060000@Sun.COM> References: <47E7723B.7040400@gmail.com> <47E802DA.20200@Sun.COM> <47E8B972.1060301@gmail.com> <47EAAC0D.4060000@Sun.COM> Message-ID: <47EABAB2.9040308@gmail.com> Mike - I am withdrawing this RTI. Your comments prompted me to do a more complete search of my build machines and it found an fts.h file that was being picked up by xmms. After removing that file, xmms builds without the patch. Sorry for the waste of our time. Steve C. Mike Sullivan wrote: > Steven M. Christensen wrote: >> Mike - >> >> I have redone the patch and Makefile.sfw as you suggest. See >> >> http://companion.sunfreeware.com/downloads/xmmswebrev/ > > ok fine. > >> >> As far as I can see, here is where fts.h appeared >> >> >> >> 4887 17-Aug-2007 chin 6437624 RFE: Add ksh93 (as >> /usr/bin/ksh93) and libshell.so to OS/Net >> 6505835 AST tools and library (libpp) required for creating l10n >> messages for ksh93 >> PSARC/2006/550 Korn Shell 93 Integration >> PSARC/2006/587 /etc/ksh.kshrc for ksh93 >> PSARC/2007/035 ksh93 Amendments >> Contributed by Roland Mainz > >> >> >> fts.h is in /usr/include/ast and elsewhere. It is in 81 >> and perhaps in slightly earlier versions. > > If that's where it first appeared, then it would be build 72. > But that's indeed in /usr/include/ast - is that really the one > that xmms picks up? It knows about ksh93's include directory? > I guess it must be as it's the only one I see in 85: > > {mike_s:yavin:435} grep fts.h */pkgmap | grep include > SUNWhea/pkgmap:1 f none usr/include/ast/fts.h 0644 root bin 5774 5390 > 1204921034 > > it's kinda weird to just find that now though, since I know we've > both built the ccd since ksh93 integrated. > >> >> If the above fix is OK I will do the commit. If this is appropriate >> for a bug report, I can do that as well if there is a good place for it. > > Well actually, now I'm a little worried. Why is xmms only finding this > now? It showed up in august, but my last ccd build was in january, and > I had that header. And I'm up to date with the ccd workspace. So what is > really going on? ack. > > Mike > From Mike.Sullivan at sun.com Wed Mar 26 14:05:07 2008 From: Mike.Sullivan at sun.com (Mike Sullivan) Date: Wed, 26 Mar 2008 14:05:07 -0700 Subject: [companion-integrate] RTI - Minor fix to xmms build In-Reply-To: <47EAAC0D.4060000@Sun.COM> References: <47E7723B.7040400@gmail.com> <47E802DA.20200@Sun.COM> <47E8B972.1060301@gmail.com> <47EAAC0D.4060000@Sun.COM> Message-ID: <47EABA83.3050108@Sun.COM> Mike Sullivan wrote: > Steven M. Christensen wrote: >> If the above fix is OK I will do the commit. If this is appropriate >> for a bug report, I can do that as well if there is a good place for it. > > Well actually, now I'm a little worried. Why is xmms only finding this > now? It showed up in august, but my last ccd build was in january, and > I had that header. And I'm up to date with the ccd workspace. So what is > really going on? ack. And isn't this fun. I just did an x86 build and nope, we don't die in xmms. However, now we do die in vim and ddd. Agh. vim dies like this: Undefined first referenced symbol in file Xutf8SetWMProperties objects/os_unix.o ld: fatal: Symbol referencing errors. No output written to vim collect2: ld returned 1 exit status but perhaps it's not interesting since vim is in the wos now. ddd seems to be upset because of this: In file included from InitImage.C:43: /usr/openwin/include/X11/Xlibint.h:45:69: X11/XlibConf.h: No such file or directory gmake[3]: *** [InitImage.o] Error 1 gmake[3]: Leaving directory `/builds/freeware-fixes/usr/src/cmd/ddd/ddd-3.3.11/ddd' gmake[2]: *** [all] Error 2 gmake[2]: Leaving directory `/builds/freeware-fixes/usr/src/cmd/ddd/ddd-3.3.11/ddd' gmake[1]: *** [all-recursive] Error 1 gmake[1]: Leaving directory `/builds/freeware-fixes/usr/src/cmd/ddd/ddd-3.3.11' *** Error code 2 make: Fatal error: Command failed for target `all' Current working directory /builds/freeware-fixes/usr/src/cmd/ddd {root:sinestro:3} ls -l /usr/openwin/include/X11/Xlibint.h lrwxrwxrwx 1 root other 37 Mar 20 13:27 /usr/openwin/include/X11/Xlibint.h -> ../../../../X11/include/X11/Xlibint.h {root:sinestro:4} ls -lL /usr/openwin/include/X11/Xlibint.h -r--r--r-- 1 root bin 37961 Mar 12 19:32 /usr/openwin/include/X11/Xlibint.h {root:sinestro:5} grep XlibConf /usr/openwin/include/X11/Xlibint.h #include /* for configured options like XTHREADS */ {root:sinestro:6} grep X11/XlibConf /var/sadm/install/contents /usr/X11/include/X11/XlibConf.h f none 0444 root bin 1578 62033 1205375564 SUNWxwinc XlibConf.h may be relatively new, I did just update to the build 86 X, JDS, and other consolidation bits as well. The ddd Makefile.sfw may need a -I/usr/X11/include or perhaps there's another configure option we need to set. Mike From sunfreeware at gmail.com Fri Mar 28 03:05:02 2008 From: sunfreeware at gmail.com (Steven M. Christensen) Date: Fri, 28 Mar 2008 06:05:02 -0400 Subject: [companion-integrate] RTI - Update of SFWnpbm (netpbm) Package Message-ID: <47ECC2CE.5060209@gmail.com> This is a RTI for the update of the netpbm package from version 10.3 to version 10.26.51 (the latest version as of this date). The webrev is at http://companion.sunfreeware.com/downloads/netpbmwebrev/ The code review was done by Paul Cunningham with no issues raised. Details: 1. Copyright dates updated to 2008 where required. 2. SCCS ids removed. 3. METADATA file added. 4. Source code file updated and version numbers fixed in various files. 5. Patches changed to correspond to most recent files. 6. SUFFIXES line removed from Makefile.sfw. 7. A number of programs have been removed in this version and those are removed from install-sfw and prototype_com. Library version updated. 8. Locations of some built files have changed and this is fixed in install-sfw. These changes build correctly and a pkgadd of the new package produces working programs. This was done on NV 81. Steve Christensen