From Mike.Sullivan at sun.com  Mon Feb  2 10:53:02 2009
From: Mike.Sullivan at sun.com (Mike Sullivan)
Date: Mon, 02 Feb 2009 10:53:02 -0800
Subject: [companion-integrate] RTI - Minor bug fix in SFWgviz (graphviz)
 Package
In-Reply-To: <4983F2C4.3050400@gmail.com>
References: <4983F2C4.3050400@gmail.com>
Message-ID: <4987410E.2070303@Sun.COM>

Steven M. Christensen wrote:
> This is a RTI for a bug fix in the graphviz package SFWgviz.
> There is an outstanding bug (CR# 5028235) filed against this package. 
> The agraph.3 man page has a line that causes catman to fail in 
> /opt/sfw/man/man3 for this file.   Removing one line fixes this and 
> still gives a working man page.
> 
> The webrev is at
> 
> http://companion.sunfreeware.com/downloads/graphvizwebrev/
> 
> This has been reviewed and approved by Paul Cunningham.
> 
> Details:
> 
> 1. A patch is created to fix the agraph.3 file.
> 2. A patch line is added in Makefile.sfw.

A patch named 'patch' bothers me - it would be much
better to have it named after what it patches, or at
least have a comment about it in Makefile.sfw. It just
seems unfriendly for someone coming along later to
update this to have to figure out what a possibly
huge generic 'patch' file is really doing.

but ok, these days I suppose it doesn't matter anymore.

	Mike