[crossbow-discuss] [Fwd: [networking-discuss] code-review: fine-grained privileges for datalink administration]

[Kais Belgaied]

Hi Seb,

the changes look good to me.
only a handful of comments:

kb-01
os/priv-defs line 390 s/PRIV_SYS_DATALINK_CONFIG/PRIV_SYS_DL_CONFIG

kb-02
aggr_ctl.c
103,106,119
how about computing (nports * sizeof (laioc_port_t)) once, save the 
result in a local variable, and use that variable,
as often as you need, instead of computing the same quantity 3 times in 
the same function

kb-03
similar comment about 224,226,243

kb-04
dld_drv.c
525,526. The context is blockable here. KM_SLEEP is fine.

kb-05
1102,1108 are returning without calling ddi_release_devi(dip).

    Kais

On 08/04/08 08:23, Sebastien Roy wrote:
> Crossbow team,
>
> The following is of interest to the Crossbow project.  Since a large
> chunk of these changes also exist in the Crossbow gate, the delivery of
> this wad will result in fewer lines of changes for Crossbow's delivery.
> If someone on Crossbow could participate in this review, that would be a
> bonus (Eric Cheng made original changes in the Crossbow gate at some
> point last year).
>
> -Seb
>