Review for 6666204 metaslot opens/closes /dev/urandom needlessly, by

[Dan Anderson]

Dina wrote:
> It probably works, but look at:
> line 50: meta_OpenRandom(int *fd) {
> line 55: while ((meta_urandom_seed_fd = open(
> line 110: rv = meta_OpenRandom(&meta_urandom_seed_fd);
> Shouldn't line 55 be
> while ((*fd = open(
> and all references to meta_urandom_seed_fd in OpenRandom
> be to *fd? Or why bother with passing in at all?
> D.

You're correct--I updated the webrev to as you suggest and I"ll test it tomorrow.

"Cut and paste considered dangerous"
 - Anon.

--
This message posted from opensolaris.org