Review for 6723237 off-by-1 error in libcryptoutil (due July 18)

[Darren J Moffat]

Garrett D'Amore wrote:
> Dan Anderson wrote:
>> Here's a review for
>> 6723237 libcryptoutil should allow mechanism number "0x80000000" (the value of marker CKM_VENDOR_DEFINED)
>>
>> It's an off-by-one error that disallows vendor-defined mechanism "0x80000000".  The fix is simple--just change the ">" to ">=".
>>
>> http://dan.drydog.com/reviews/6723237-libcryptoutil/
>>
>> Please reply by Friday July 18.  Thanks.
>>
>> --
>> This message posted from opensolaris.org
>> _______________________________________________
>> crypto-discuss mailing list
>> crypto-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/crypto-discuss
>>   
> Looks good to me, but *usr/src/cmd/cmd-crypto/cryptoadm/adm_uef.c *and* 
> **usr/src/lib/pkcs11/pkcs11_kernel/common/kernelUtil.c*  don't look like 
> they have any changes in them (or perhaps there was whitespace only 
> change that doesn't show up in Sdiffs?)

I can see the change with the sdiffs.  It is a > to a >= on line 451 for 
adm_uef.c and line 251 for kernelUtil.c.



-- 
Darren J Moffat