code review request for 6545046

[Dina]

Me too.

Ferenc Rakoczi wrote:
> Looks good to me.
> 
> Ferenc
> 
> Valerie Bubb Fenwick wrote:
>> Hi everyone -
>>
>> This got held up in moderation, but Derek still needs a review.
>> I'm his sponsor, so don't want to be the only code reviewer. I'd
>> also like to get this in before the mercurial transition.
>>
>> Thank you,
>>
>> Valerie
>>
>> On Thu, 10 Jul 2008, Derek Morr wrote:
>>
>>> I'm seeking review for 6545046. The diff is at 
>> http://www.personal.psu.edu/~dvm105/pkcs7_patch.txt
>>
>> The PKCS11 softtoken doesn't properly check the PKCS7 padding. Per the 
>> PKCS7 spec[1],
>>
>> "...the method shall be to pad the input at the trailing end with k ÿÿ 
>> (l mod k) octets all having value k ÿÿ (l mod k), where l is the length 
>> of the input." (section 10.3, note 2).
>>
>> Please reply by Friday, July 18.
>>
>> -derek
>>
>> [1] ftp://ftp.rsasecurity.com/pub/pkcs/ps/pkcs-7.ps
>> _______________________________________________
>> crypto-discuss mailing list
>> crypto-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/crypto-discuss
>>
>>
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> crypto-discuss mailing list
>> crypto-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/crypto-discuss
> _______________________________________________
> crypto-discuss mailing list
> crypto-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/crypto-discuss