Review for 5031131 (performance improvement to libcryptoutil) (due July

[Krishna Yenduri]

Dina wrote:
> If you're going to work on that, then I have this for you too.  :)
>
> borg:/net/borg.sfbay/cube/builds/dinak/cryptoutil-rfe/
>     usr/src/lib/libcryptoutil/common/typestr.c
>
> 6440054 enhance libcryptoutil with some new string functions and 
> attribute checking functions

 It is Dan's call. But, I don't think this RFE belongs with 5031131.

 I suggested fixing 4947627, which is a bug, because it affects
 the check for mechid (> CKM_VENDOR_DEFINED vs.
 >= CKM_VENDOR_DEFINED)  in the changes for 5031131.

 Dan, I am fine with it if you decide to make just this change and
 not fix the rest of 4947627.

Regards,
-Krishna

>
>
> Ideally mech2str/str2mech is a further extension of what was in
> type2str/str2type.  Plus there are some other things in there, all
> in the name of code reuse.
>
> D.
>
> Krishna Yenduri wrote:
>> Dan,
>>
>>> I updated webrev at--please re-review:
>>>
>>> http://dan.drydog.com/reviews/5031131-libcryptoutil/
>>>   
>>
>>  While you are here, can you please also fix
>>  4947627 improve libcrypto string/mechanism conversion functions in 
>> edge cases
>>
>>  I started wondering about why the checks are not for
>>  mechid >= CKM_VDENDOR_DEFINED and then found
>>  this bug.
>>
>> -Krishna
>> _______________________________________________
>> crypto-discuss mailing list
>> crypto-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/crypto-discuss