Review for SHA2 x86_64 assembler optimizations (due March 19)

[Krishna Yenduri]

Dan Anderson wrote:
> Here's a review for CR 6665607 Need a SHA256/SHA384/SHA512 implementation optimized for 64-bit x86
> http://dan.drydog.com/reviews/6665607-sha2/
>   

 usr/src/common/crypto/sha2/amd64/sha512-x86_64.pl
KY-1    lines 220, 314  T3
 No need for these lines as this is just a digest algorithm.

usr/src/lib/libmd/amd64/Makefile
KY-2    lines 44-59     T4
 Consider making this a single rule using a pattern matching
 rule to match all the file names (I think it is %).

usr/src/lib/pkcs11/pkcs11_softtoken/Makefile.com
KY-3    lines 135-136
 Does this mean we have been linking sha1 and sha2 objects
 in to softtoken library so far! Good catch.

usr/src/uts/intel/sha2/Makefile
KY-4    lines 105-118   T4
 You don't need these rules if the SHA2_OBJS entry
 is moved to usr/src/uts/intel/Makefile.files.
 If they need to stay here, consider having a single rule
 for sha512-x86_64.o and sha256-x86_64.o by using
 pattern matching rules (I think it is %).


-Krishna