Code review: libsoftcrypto.so - due Friday Oct 24th

[Anthony Scarpino]

Anthony Scarpino wrote:
> Dan Anderson wrote:
>> One comment, everything else LGTM.
>> - Dan
>>
>> DEA-1 usr/src/lib/pkcs11/pkcs11_softtoken/Makefile.com
>> Lines 94-102 (AESDIR, ARCFOURDIR, BIGNUMDIR) can be removed,
>> as should be usage below in -I lines, lines 123 and 125.
>> This will help verify the code has been removed to libsoftcrypto
> 
> accepted.. thanks..
> 
> Tony

So I accepted this comment because the compile I did to verify I needed 
these includes, but it showed that I didn't.. Now compiling this today 
caused failures.   I must not have 'make clobber' or something the first 
time..

The reason these includes need to be kept is the softtoken functions are 
still calling the algorithms directly.  In the case of softAESCrypt.c, 
it still includes aes_impl.h and calls many aes functions.

So in the end I have to reject the change.. thanks though, good to keep 
me on my toes :)

Tony