Review for bignum library amd64 performance improvement with 64-bit chunks

[Dan Anderson]

> On Feb 25, 2009, krishna wrote:
>  Looks good. I have one comment below.
> > <         for (i = nlen - 1; (i > 0) && (rr[i] == 0); i--
> >            ret->len = i + 1;  
> 
> I would recommend adding a comment on why rr[0] is
>  not checked.

ADDED.

> Also, please check to see that no other for loops
> exist with the same problem.

I did that already.  The only thing I found was one other loop, but it already had the fix (that is, compared > 0 instead of >= 0).

Thanks for the review.
-- 
This message posted from opensolaris.org