code review for 6808439

[Krishna Yenduri]

Mark,

> I need a code review for
> 6808439 mode code should not special case inplace operations
>
> The webrev is at
> http://cr.opensolaris.org/~mcpowers/inplace

 I see that we have less number of steps in the old code for the inplace 
case
 presumably for performance. For example, in modes/ecb.c, we don't do
 the following for inplace case -
 crypto_init_ptrs(), crypto_get_ptrs() and bcopy().
 The extra bcopy concerns me.

 Please check if there is any performance impact for the inplace case
 with your changes. Hopefully, it is insignificant.

-Krishna