[desktop-discuss] Re: Xfce

[Doug Scott]

> > > Doug Scott wrote:
> > Yeah, there is a lot of gcc funk in the header
> files.
> > The G_BEGIN_DECLS ended with semi-colons are the
> > easiest to fix (using 'find' and a 'ex' script).
> It
> > is the G_GNUC_HIDDEN etc put at the end of a
> function
> > definition which take a lot of editing to fix. I
> have
> > been considering writing a small C program to move
> > the annotations to the front of the function so
> Sun
> > Pro C doesn't barth. Of course getting Sun Pro to
> > accept either is the best solution, but out of my
> > control.... 
> 
> This sounds like the G_GNUC_INTERNAL changes that had
> to be made throughout the JDS source.
> e.g. in glib:
> -void _g_debug_init (void) G_GNUC_INTERNAL;
> +G_GNUC_INTERNAL void _g_debug_init (void);
> 
> Brian Cameron enhanced glib's definition of
> G_GNUC_INTERNAL to make it non-blank and useful on
> the forte compiler.

Yep, thats them. It is actually a good move performance wise for the compiler to not advertise the internal function calls. Xfce has been very well written, but there are literally hundreds of functions definitions which need to be edited for Sun Pro. I could have taken the easy method and just used ex or sed to remove the annotations, but then we would have lost their benfits.

Doug
 
 
This message posted from opensolaris.org