[desktop-discuss] Gamin???

[Menno Lageman]

Glynn Foster wrote:
> Hey,
> 
> James Litchfield wrote:
>> Fired up prstat the other day and noticed something new: gam_server was
>> running around madly stating files. This seems to be
>>
>> http://www.gnome.org/~veillard/gamin/
>>
>> The obvious question is why not use the Solaris file monitoring
>> capabilities instead of stating the world away....
> 
> Gamin is currently built with a patch that should enable Solaris' FEM -
> 
> http://src.opensolaris.org/source/xref/jds/spec-files/trunk/patches/gamin-01-all.diff
> 
> hopefully others on the list will be able to say why it's behaving this way.
> 

Hmmm,

is this a finished patch? A cursory look turns up this:

1642 +	if (getrctl ("process.max-port-events", NULL, rblk, RCTL_FIRST) 
== -1) {
1643 +		perror ("getrctl");
1644 +		exit (1);
1645 +	} else {
1646 +		if (max_port_evnets > rctlblk_get_value(rblk))
1647 +			max_port_evnets = rctlblk_get_value(rblk);
1648 +		GAM_DEBUG(DEBUG_INFO, "FENKERNEL : max event of a port: %u\n", 
max_port_evnets);
1649 +	}

Reading the code, 'max_port_evnets' is obviously a typo-ed version of 
'max_port_events'. However, rather then correcting the typo, a 
max_port_evnets variable was added, directly above (!) the spot where 
the correctly spelled variable is declared:

1309 +
1310 +static ulong max_port_evnets = 512;
1311 +static ulong max_port_events = 256;
1312 +static GList *pn_vq;	/* the queue of ports which don't have the 
max objs */


Cheers,

Menno

-- 
Menno Lageman - Sun Microsystems - http://blogs.sun.com/menno