[driver-discuss] [networking-discuss] looking for reviewers... review dnet changes! (suspend/resume and amd64 support!)

[James Carlson]

Garrett D'Amore writes:
> I've been looking for folks to review the following changes to dnet, 
> which adds 64-bit support (amd64) and also suspend/resume support.
> 
> http://cr.opensolaris.org/~gdamore/dnet-suspend/

dnet.c:

  344: the RTI advocates seem to be asking about these ugly SCCS
  keywords in module names due to the Mercurial transition.  You might
  do well to ditch this now.

  577: why is txlock held while doing dnet_reset_board and
  dnet_init_board?  The other callers don't do this.

  892: similar comment here for dnet_reset_board.

  982,984: not your problem, but I doubt these locks do much.

  1227: nit; macaddr could be const.

-- 
James Carlson, Solaris Networking              <james.d.carlson at sun.com>
Sun Microsystems / 35 Network Drive        71.232W   Vox +1 781 442 2084
MS UBUR02-212 / Burlington MA 01803-2757   42.496N   Fax +1 781 442 1677