[Duckwater-discuss] Final Duckwater Phase 0 webrev

[Julian Pullen]

Milan,

The I have spoken to Tomas about the bug and we think it is very
unlikely to happen. The bug will be recorded via a CR. We are trying
to get the software back in the current build. I don't like changing
things at last minute. We would rather fix the bug after the current
build.


Regards

Julian

Milan Jurik wrote:
> Hi Tomas,
> 
> Tomas Heran píše v Po 09. 06. 2008 v 14:29 +0200:
>> Julian Pullen wrote:
>>> Tomas,
>>>
>>> I did not get any reply about my comment below. I have checked the
>>> source and it has not changed.
>>>
>>> Regards
>>>
>>> Julian
>>>
>>> Second review of ns_confmgr.c
>>> -----------------------------
>>>
>>> set_attr() line 262 should be
>>>
>>>  260         /* This double call is made due to the presence of */
>>>  261         /* two sets of LDAP config. attribute names. */
>>>  262         if (__s_api_get_profiletype(attr_name, &idx) < 0 ||
>>>  263             __s_api_get_versiontype(config_struct, attr_name, &idx) 
>>> < 0) {
>> We must've missed it. Sorry about that. We probably don't have time to
>> fix it now, but will fix it as a separate CR.
>>
> 
> What time? Are we under time pressure? When? Why? It is not acceptable
> to putback something where we know about CRs already (I agreed with one
> my RFE case, code refactoring, but not in this case). This one is very
> simple to fix and I see no reason for putback. 
> 
> And btw. I see e.g. that even comment is not formatted as it should be.
> 
> Actually if it will not be fixed before RTI, please, remove my name from
> code reviewers list.
> 
> Best regards,
> 
> Milan
>