[ext3-discuss] Code review request - empty dir test

[Milan Čermák]

Jan Senolt napsal(a):
> Hi Milan,
> good point, thank you. I removed 'complete' and also reverted changes in Makefile.master. New webrev is here http://cr.opensolaris.org/~senoltj/dir-fix03
> Best regards,
> Jan

Great. I like it, now.
Milan

> ______________________________________________________________
>> Od: Milan.Cermak at Sun.COM
>> Komu: Jan Senolt <senoltj at centrum.cz>
>> CC: ext3-discuss at opensolaris.org
>> Datum: 09.03.2009 08:41
>> Předmět: Re: [ext3-discuss] Code review request - empty dir test
>>
>> Hi Jan,
>> it looks good. I have only one comment. I think you can eliminate 'complete' variable by setting 'error' to ENOTEMPTY on line 429.
>> Then, you can also remove lines 443 and 444.
>>
>> Regards,
>> Milan Čermák
>>
>> Jan Senolt napsal(a):
>>> Hi,
>>> I have uploaded a new webrev, i hope this is correct one now:-) It is available here: http://cr.opensolaris.org/~senoltj/dir-fix02/
>>>> Function ext2_isdirempty() is fixed: 'used_entry_counter' is now incremented only if directory entry is used (line 421) and loops are interrupted immediately after reaching 3 used entries (line 424). > There are also some small lint related corrections and one change in Makefile (for newer cc).
>>> Thank you.
>>>> Best regards,
>>> Jan
>> -- * There is an ancient curse saying: 'Interesting times on you.' *
>>
>>
> 
> _______________________________________________
> ext3-discuss mailing list
> ext3-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/ext3-discuss

-- 
* There is an ancient curse saying: 'Interesting times on you.' *