[fuse-discuss] Re: code for review

[Mark Phalan]

On Sat, 2007-03-17 at 23:14 -0500, Sunil wrote:
> Hi all,
> 
> I have implemented following vnode operations for fuse kernel module on 
> Solaris:
> 
> lookup
> create
> readlink
> 
> The webrev generated diff's of the latest changes is available here: 
> http://www-users.cs.umn.edu/~subram/webrev/
> Please feel free to provide any feedback. Depending on the review 
> comments I would expect the changes to be committed in to the repository 
> in a week or two.
> 
> Thanks,
> Sunil

Hi Sunil,

Sorry for the delay in looking at this.. I just have a few extra
comments/nits:

fuse_queue.c
NIT 183: "did'nt" should be "didn't" 

fuse_vfsops.c
NIT 248-251: badly formatted comment.
NIT 257: I'd prefer to see the else statement using '{' and '}'.
279: I think it would be better to use a define in place of the '0'
argument to fuse_create_vnode (and elsewhere where this func is called).

fuse_vnops.c
199: If we use BSD code then we need to add a BSD copyright to the top
of the file.
247,283,928,1132: stcpy is dangerous (think buffer overflows). Use
strlcat or strlcpy instead.
1637: Should check the return code here.


Cheers,

-Mark