[fuse-discuss] Re: code for review: cstyle, lint cleanup

[subra056 at umn.edu]

Hi Mark,

Below are a few inconsistencies that I noticed which I guess cstyle has 
failed to bring up.

Regards,
Sunil


fuse_dev.c : 
             Lines 167-172, 183-187, 195-202 :- Indentation has extra tab 
spaces.
             Lines 122, 154, 178, 191, 206, 212, 239, 250, 258,328 :- 
Functions do not have return type on a seperate line.

fuse_vnops.c: 
             Lines 530-533, 582-585 :- Debug statement might need to be
moved below the variable declaration as done in other cases.

             Lines 1733-1747 :- Indentation has extra tab spaces.


On 4/20/07, Mark Phalan <Mark.Phalan at sun.com> wrote:
>
>
> I've made fusefs cstyle clean and (mostly) lint clean.
> The webrev can be found here:
> http://cr.grommit.com/~mbp/fuse_cstyle_lint/webrev/
>
> I used webrev.sh from
>
>  
> http://src.opensolaris.org/source/xref/scm-migration/onnv-scm/usr/src/tools/scripts/webrev.sh
>
> Some of the whitespace in the webrevs look strange to me... Look at the
> "raw" files if you have any doubt. Also the framed diffs seem to be
> broken - I'm not sure why, they work locally. You may want to download
> the webrev as a tarball and look at it locally. Get it here:
> http://cr.grommit.com/~mbp/fuse_cstyle_lint/webrev.tar.gz
>
> For those who may not be aware cstyle is a tool we use to ensure a
> consistent C style in Solaris/OpenSolaris. It can be found here:
>
>  
> http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/tools/scripts/cstyle.pl
>
> Usage:
> cstyle <file1.c> <file2.c> ...
>
>
> The code is not totally lint clean, eventually it should be. Most of the
> current lint errors are to do with function arguments not being used,
> code we know will be replaced (fuse_opcodes.h) etc. This should change
> over time (or we can just tell lint to ignore these errors).
>
> I ran lint as follows:
> lint -sx -errtags=yes -Xc99=%none -errsecurity=extended
> -erroff=E_PTR_CONV_LOSES_BITS  -D__SOLARIS__ -D_KERNEL <file.c>
>
>
> Cheers,
>
> -Mark
>
>
>
>
>