[fuse-discuss] fuse_fs_statvfs() for review

[Sunil Kumar T Subramanya]

Hi Mark,

Here are few of my comments:

Line 532         cmn_err(CE_NOTE, "File[%s], Line[%d]: Inside fuse_statvfs\n",

Can this be replaced with DEBUG?

 542         msgp = fuse_setup_message(0, FUSE_STATFS, 0, sep->usercred,
 543             FUSE_GET_UNIQUE(sep));
Instead of calling fuse_setup_message(), I think we can use setup_msg_onlyheader() which was meant for creating a message without any arguments.

I was looking at FreeBSD Fuse implementation of the same call, they pass nodeid of root vnode, so I was wondering if same can be done here instead of passing zero?

The other webrev changes of i386 cleanups and post build 62 fixes look fine to me.

Regards,
Sunil
--
This messages posted from opensolaris.org