[fuse-discuss] fuse_fs_statvfs() for review

[Mark Phalan]

On Wed, 2007-08-08 at 09:00 +0200, Frank Batschulat (Home) wrote:
> On Wed, 08 Aug 2007 06:05:12 +0200, Sunil Kumar T Subramanya <subra056 at umn.edu> wrote:
> 
> > Hi Mark,
> >
> > Here are few of my comments:
> >
> > Line 532         cmn_err(CE_NOTE, "File[%s], Line[%d]: Inside fuse_statvfs\n",
> >
> > Can this be replaced with DEBUG?
> 
> or alternatively consider using SDT dtrace probes in such situations, e.g. DTRACE_PROBE2()
> 
> http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/uts/common/sys/sdt.h#47
> 

Yes, this is something I've been thinking about for a while. A lot of
the current DEBUG()s just print out when a function is entered or
exit'ed - these could just be removed and fbt provider be used instead.
As regards the DEBUG()s which don't fall into this category they could
probably be mostly replaced with STD probes..

I've been wary of pulling out anything which helps debugging so far - we
don't want to make our job more difficult. However now may be the time
to do it, with DEBUG() enabled there is LOTS of output. Dtrace would
make this manageable again.

I'll take a look at this when I get the time.

-Mark