[fuse-discuss] fuse_fs_statvfs() for review

[Mark Phalan]

On Tue, 2007-08-07 at 21:05 -0700, Sunil Kumar T Subramanya wrote:
> Hi Mark,
> 
> Here are few of my comments:
> 
> Line 532         cmn_err(CE_NOTE, "File[%s], Line[%d]: Inside fuse_statvfs\n",
> 
> Can this be replaced with DEBUG?

I'll make the change (caveat: see the mail I just sent to Frank
Batschulat).

> 
>  542         msgp = fuse_setup_message(0, FUSE_STATFS, 0, sep->usercred,
>  543             FUSE_GET_UNIQUE(sep));
> Instead of calling fuse_setup_message(), I think we can use setup_msg_onlyheader() which was meant for creating a message without any arguments.
> 

Well I took a look at the implementation for fuse_setup_message() - its
pretty much identical to setup_msg_onlyheader() when called with an
argsize of '0'. I think it makes more sense to use fuse_setup_message()
and dump setup_msg_onlyheader() completely - it makes things more
consistent and readable.
One other advantate of using fuse_setup_message() is that it allocates
the header for the caller whereas setup_msg_onlyheader() doesn't.

> I was looking at FreeBSD Fuse implementation of the same call, they pass nodeid of root vnode, so I was wondering if same can be done here instead of passing zero?
> 

That makes sense. I'll make that change.

> The other webrev changes of i386 cleanups and post build 62 fixes look fine to me.
> 

Thanks,

-Mark