From don.anthony.lee at gmail.com Fri Mar 7 13:38:57 2008 From: don.anthony.lee at gmail.com (Anthony Lee) Date: Sat, 8 Mar 2008 05:38:57 +0800 Subject: [g11n-dev] [REVIEW][SunPinyin] enhancement & fixing for IME Message-ID: <638bf0dd0803071338tb2e1d9cw42fc235b5d8f0a47@mail.gmail.com> Hi guys, I need your help to review the changes listed below. :) CIMIModerView of IME core ------------------------- Patch: ime-core.diff 1. Changes: 1) Implemented editable syllable modification. 2) Fixed behavior when user pressed ESC. 3) Fixed BUGS when user pressed ` to dismiss converted character to pinyin then continue to edit. 2. Modified files: sunpinyin/ime/src/imi_view_modern.cpp sunpinyin/ime/src/imi_view_modern.h BeOS wrapper of SunPinyin IME ------------------------------ Patch: beos-wrapper.diff 1. Changes 1) Corrected behavior when user press SHIFT+X. 2) Cleaning "SunPinyinStandalone.cpp" and modified something when use Lite BeAPI. 2. Modified files: sunpinyin/ime/wrapper/beos/SunPinyinModule.cpp sunpinyin/ime/wrapper/beos/SunPinyinStandalone.cpp Thanks. Anthony Lee -------------- next part -------------- A non-text attachment was scrubbed... Name: ime-core.diff Type: text/x-patch Size: 7217 bytes Desc: not available URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: beos-wrapper.diff Type: text/x-patch Size: 7172 bytes Desc: not available URL: From Yong.Sun at Sun.COM Sun Mar 9 09:14:23 2008 From: Yong.Sun at Sun.COM (Yong Sun) Date: Mon, 10 Mar 2008 00:14:23 +0800 Subject: [g11n-dev] [REVIEW][SunPinyin] enhancement & fixing for IME In-Reply-To: <638bf0dd0803071338tb2e1d9cw42fc235b5d8f0a47@mail.gmail.com> References: <638bf0dd0803071338tb2e1d9cw42fc235b5d8f0a47@mail.gmail.com> Message-ID: <47D40CDF.9000108@Sun.COM> Hi, Anthony, I found one problem, here is the steps to reproduce, 1. input the following pinyin sequences, 'wending', and then you would see the preedit string as '?ding', 2. move the caret to 'g', and then insert a 'g', then the output is '??g' 3. move the caret to the end, and delete the entire preedit string 4. input 'wending' again, you would see the preedit string is messy Maybe the syllable segmenting is incorrect in this situation. Regards, Anthony Lee ??: > Hi guys, > > I need your help to review the changes listed below. :) > > CIMIModerView of IME core > ------------------------- > Patch: ime-core.diff > 1. Changes: > 1) Implemented editable syllable modification. > 2) Fixed behavior when user pressed ESC. > 3) Fixed BUGS when user pressed ` to dismiss converted character to > pinyin then continue to edit. > > 2. Modified files: > sunpinyin/ime/src/imi_view_modern.cpp > sunpinyin/ime/src/imi_view_modern.h > > > BeOS wrapper of SunPinyin IME > ------------------------------ > Patch: beos-wrapper.diff > 1. Changes > 1) Corrected behavior when user press SHIFT+X. > 2) Cleaning "SunPinyinStandalone.cpp" and modified something when > use Lite BeAPI. > > 2. Modified files: > sunpinyin/ime/wrapper/beos/SunPinyinModule.cpp > sunpinyin/ime/wrapper/beos/SunPinyinStandalone.cpp > > > Thanks. > Anthony Lee > > ------------------------------------------------------------------------ > > _______________________________________________ > g11n-dev mailing list > g11n-dev at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/g11n-dev From don.anthony.lee at gmail.com Sun Mar 9 13:11:58 2008 From: don.anthony.lee at gmail.com (Anthony Lee) Date: Mon, 10 Mar 2008 04:11:58 +0800 Subject: [g11n-dev] [REVIEW][SunPinyin] enhancement & fixing for IME In-Reply-To: <47D40CDF.9000108@Sun.COM> References: <638bf0dd0803071338tb2e1d9cw42fc235b5d8f0a47@mail.gmail.com> <47D40CDF.9000108@Sun.COM> Message-ID: <638bf0dd0803091311m1f8652c9i4e64dd031bf2acfc@mail.gmail.com> Hi Yong, > I found one problem, here is the steps to reproduce, > 1. input the following pinyin sequences, 'wending', and then you would > see the preedit string as '?ding', > 2. move the caret to 'g', and then insert a 'g', then the output is '??g' > 3. move the caret to the end, and delete the entire preedit string > 4. input 'wending' again, you would see the preedit string is messy Thanks for your help, the following patch can fix that. ********************************************************************** --- imi_view_modern.cpp (previous patched) +++ imi_view_modern.cpp (fixed) @@ -439,7 +439,8 @@ } else if (keycode == IM_VK_RIGHT) { if (m_CursorIdx >= 0 && m_CursorIdx < m_SyllableStr.size()) { mask |= PREEDIT_MASK; - m_CursorIdx++; + if (++m_CursorIdx == m_SyllableStr.size()) + m_CursorIdx = -1; } } else if (keycode == IM_VK_HOME) { if (m_CursorIdx != 0) { ********************************************************************** B.R. Lee From don.anthony.lee at gmail.com Sun Mar 9 13:18:32 2008 From: don.anthony.lee at gmail.com (Anthony Lee) Date: Mon, 10 Mar 2008 04:18:32 +0800 Subject: [g11n-dev] [REVIEW][SunPinyin] enhancement & fixing for IME In-Reply-To: <638bf0dd0803091311m1f8652c9i4e64dd031bf2acfc@mail.gmail.com> References: <638bf0dd0803071338tb2e1d9cw42fc235b5d8f0a47@mail.gmail.com> <47D40CDF.9000108@Sun.COM> <638bf0dd0803091311m1f8652c9i4e64dd031bf2acfc@mail.gmail.com> Message-ID: <638bf0dd0803091318k3a378c69oaabdbc78cb88a5a1@mail.gmail.com> Hi guys, Here is another enhancement for IME core. Patch: classic_view_edit.diff 1. Changes: improving behavior when user press ` For example, if IME without this patch, you can follow the steps below to find out what happenz. type "fan gan" move the cusor after 'g' then press ` there are no "??" within candidates list. 2. Modified files: sunpinyin/ime/src/imi_view_classic.cpp B.R. A.L. -------------- next part -------------- A non-text attachment was scrubbed... Name: classic_view_edit.diff Type: text/x-patch Size: 2792 bytes Desc: not available URL: From Yong.Sun at Sun.COM Sun Mar 9 18:56:41 2008 From: Yong.Sun at Sun.COM (Yong Sun) Date: Mon, 10 Mar 2008 09:56:41 +0800 Subject: [g11n-dev] [REVIEW][SunPinyin] enhancement & fixing for IME In-Reply-To: <638bf0dd0803091311m1f8652c9i4e64dd031bf2acfc@mail.gmail.com> References: <638bf0dd0803071338tb2e1d9cw42fc235b5d8f0a47@mail.gmail.com> <47D40CDF.9000108@Sun.COM> <638bf0dd0803091311m1f8652c9i4e64dd031bf2acfc@mail.gmail.com> Message-ID: <47D49559.6080409@Sun.COM> Hi, Anthony, Thanks for the quick fix, please continue to check in. Regards, Anthony Lee ??: > Hi Yong, > > >> I found one problem, here is the steps to reproduce, >> 1. input the following pinyin sequences, 'wending', and then you would >> see the preedit string as '?ding', >> 2. move the caret to 'g', and then insert a 'g', then the output is '??g' >> 3. move the caret to the end, and delete the entire preedit string >> 4. input 'wending' again, you would see the preedit string is messy >> > > Thanks for your help, the following patch can fix that. > > > ********************************************************************** > --- imi_view_modern.cpp (previous patched) > +++ imi_view_modern.cpp (fixed) > @@ -439,7 +439,8 @@ > } else if (keycode == IM_VK_RIGHT) { > if (m_CursorIdx >= 0 && m_CursorIdx < m_SyllableStr.size()) { > mask |= PREEDIT_MASK; > - m_CursorIdx++; > + if (++m_CursorIdx == m_SyllableStr.size()) > + m_CursorIdx = -1; > } > } else if (keycode == IM_VK_HOME) { > if (m_CursorIdx != 0) { > ********************************************************************** > > > B.R. > Lee > From Yong.Sun at Sun.COM Sun Mar 9 19:14:21 2008 From: Yong.Sun at Sun.COM (Yong Sun) Date: Mon, 10 Mar 2008 10:14:21 +0800 Subject: [g11n-dev] [REVIEW][SunPinyin] enhancement & fixing for IME In-Reply-To: <638bf0dd0803091318k3a378c69oaabdbc78cb88a5a1@mail.gmail.com> References: <638bf0dd0803071338tb2e1d9cw42fc235b5d8f0a47@mail.gmail.com> <47D40CDF.9000108@Sun.COM> <638bf0dd0803091311m1f8652c9i4e64dd031bf2acfc@mail.gmail.com> <638bf0dd0803091318k3a378c69oaabdbc78cb88a5a1@mail.gmail.com> Message-ID: <47D4997D.4070708@Sun.COM> Hi, Anthony, Thanks for the wonderful fix, please continue to check in. Regards, Anthony Lee ??: > Hi guys, > > Here is another enhancement for IME core. > > Patch: classic_view_edit.diff > 1. Changes: > improving behavior when user press ` > > For example, if IME without this patch, you can follow the steps below > to find out what happenz. > > type "fan gan" > move the cusor after 'g' then press ` > there are no "??" within candidates list. > > > 2. Modified files: > sunpinyin/ime/src/imi_view_classic.cpp > > > > B.R. > A.L. > > ------------------------------------------------------------------------ > > _______________________________________________ > g11n-dev mailing list > g11n-dev at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/g11n-dev From Jan.Hnatek at Sun.COM Tue Mar 11 08:13:15 2008 From: Jan.Hnatek at Sun.COM (Jan Hnatek) Date: Tue, 11 Mar 2008 16:13:15 +0100 Subject: [g11n-dev] write access to nv-g11n/g11n Message-ID: <47D6A18B.6080101@sun.com> Hi, I'm trying to set up write access to ssh://hg.opensolaris.org/hg/nv-g11n/g11n, but without success. I uploaded my DSA key, but it's not working and the ssh connection defaults to keyboard-interactive. Can anyone help please? Jan -- Jan Hnatek jan.hnatek at sun.com From don.anthony.lee at gmail.com Thu Mar 27 11:49:30 2008 From: don.anthony.lee at gmail.com (Anthony Lee) Date: Fri, 28 Mar 2008 02:49:30 +0800 Subject: [g11n-dev] [SunPinyin][Review 1/1] Fixing for beos_wrapper Message-ID: <638bf0dd0803271149x2ebd8de2x48bd42c9fa5b3983@mail.gmail.com> Hi guys, Help me to review the changes please. Changes: 1. Fixed lost characters issue when using "Instant style". 2. Added a new option: Incomplete pinyin. "NonCompleteSyllabe(true)" made me confused sometimes. :) Modified files: sunpinyin/ime/wrapper/beos/SunPinyinLocale.cpp sunpinyin/ime/wrapper/beos/SunPinyinModule.cpp sunpinyin/ime/wrapper/beos/SunPinyinModule.h -------------- next part -------------- A non-text attachment was scrubbed... Name: beos_wrapper_fixing.diff Type: text/x-patch Size: 6626 bytes Desc: not available URL: