[ha-clusters-discuss] Request for code review for bug 6618681

[abhilash tg]

Hi,

Thank you all for your support and patience for helping me.


regards
Abhilash

2008/7/23 Thorsten Frueauf <Thorsten.Frueauf at sun.com>:

> Hi Abhilash, Swathi et al,
>
> sorry for the late review, and thanks for providing the webrev.
>
> I am fine with the changes.
>
> Greets
>      Thorsten
>
>
> Swathi Devulapalli wrote:
>
>> Hi,
>>
>> Thank you, Marty, Neil and Detlef for taking time to review the code.
>>
>> Regards,
>> Swathi
>>
>> Detlef Ulherr wrote:
>>
>>> Hi Swathi and Abhilash,
>>>
>>> it looks good.
>>>
>>> Detlef
>>>
>>> Swathi Devulapalli wrote:
>>>
>>>
>>>> Hi,
>>>>
>>>> On behalf of Abhilash T G, I have posted the webrev on opensolaris.org.
>>>> @ http://cr.opensolaris.org/~sdevulap/ha-jsas_CR6618681/<http://cr.opensolaris.org/%7Esdevulap/ha-jsas_CR6618681/>
>>>> for better readability.
>>>>
>>>> Please review the same and let me know your comments.
>>>>
>>>> Thanks,
>>>> Swathi
>>>>
>>>> Swathi Devulapalli wrote:
>>>>
>>>>
>>>>> Hi,
>>>>>
>>>>> The fix that Abhilash has done is in the RTR file
>>>>> usr/src/cmd/ha-services/cmd/jsas-na/SUNW.jsas-na  in the "DESCIPTION"
>>>>> field of the extension property Agentdir.
>>>>>
>>>>> {
>>>>>        PROPERTY = Agentdir;
>>>>>        EXTENSION;
>>>>>        STRING;
>>>>>        DEFAULT = "";
>>>>>        TUNABLE = WHEN_DISABLED;
>>>>>        DESCRIPTION = "The complete Path to the Node Agent Directory ";
>>>>> } "
>>>>>
>>>>> I have done the required testing for this on Glassfish on Cluster
>>>>> Express build_22b. Created/Started DAS and Node Agent resources.
>>>>> Here is the output:
>>>>> scrgadm -pvvv | grep -i AgentDir
>>>>>    (SUNW.jsas-na:3.2) Res Type param name:        Agentdir
>>>>>      (SUNW.jsas-na:3.2:Agentdir) Res Type param extension: True
>>>>>      (SUNW.jsas-na:3.2:Agentdir) Res Type param per-node: False
>>>>>      (SUNW.jsas-na:3.2:Agentdir) Res Type param description: The
>>>>> complete Path to the Node Agent Directory
>>>>>      (SUNW.jsas-na:3.2:Agentdir) Res Type param tunability: When
>>>>> disabled
>>>>>      (SUNW.jsas-na:3.2:Agentdir) Res Type param type: String
>>>>>      (SUNW.jsas-na:3.2:Agentdir) Res Type param min length: <unset>
>>>>>      (SUNW.jsas-na:3.2:Agentdir) Res Type param max length: <unset>
>>>>>      (SUNW.jsas-na:3.2:Agentdir) Res Type param default: <NULL>
>>>>>    (rg:na-rs) Res property name:             Agentdir
>>>>>      (rg:na-rs:Agentdir) Res property class: extension
>>>>>      (rg:na-rs:Agentdir) Res property description: The complete Path
>>>>> to the Node Agent Directory
>>>>>    (rg:na-rs:Agentdir) Res property pernode: False
>>>>>      (rg:na-rs:Agentdir) Res property type:  string
>>>>>      (rg:na-rs:Agentdir) Res property value:
>>>>> /glassfish/glassfish/nodeagents
>>>>>
>>>>> Thanks,
>>>>> Swathi
>>>>>
>>>>>
>>>>> abhilash tg wrote:
>>>>>
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>>
>>>>>>  I am submitting the fix for bug 6618681
>>>>>>
>>>>>> The bug synopsis is
>>>>>>
>>>>>> Bug ID            6618681
>>>>>> Synopsis         Extension property agentdir description is given as
>>>>>> domain directory instead of Node agent directory
>>>>>> State         1-Dispatched (Default State)
>>>>>> Category:Subcategory         suncluster:ha-s1as
>>>>>> Keywords         Reported Against         3.2_fcs
>>>>>> Duplicate Of         Introduced In         Commit to Fix         Fixed
>>>>>> In         Release Fixed         Related Bugs         Submit Date
>>>>>> 18-OCT-2007
>>>>>> Last Update Date         18-OCT-2007
>>>>>> Description
>>>>>> Param name:                                   Agentdir
>>>>>>    Extension:                                     True
>>>>>>    Per-node:                                      False
>>>>>>    Description:                                   The complete Path
>>>>>> to the Domain Directory
>>>>>>    Tunability:                                    When disabled
>>>>>>    Type:                                          String
>>>>>>    Min length:                                    <Unset>
>>>>>>    Max length:                                    <Unset>
>>>>>>    Default:                                       <NULL>
>>>>>>
>>>>>> Work Around
>>>>>> N/A
>>>>>>
>>>>>>
>>>>>> My sponsor has done the testing.
>>>>>>
>>>>>> regards
>>>>>> Abhilash
>>>>>>
>>>>>
> --
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>  Sitz der Gesellschaft:
>  Sun Microsystems GmbH, Sonnenallee 1, D-85551 Kirchheim-Heimstetten
>  Amtsgericht Muenchen: HRB 161028
>  Geschaeftsfuehrer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer
>  Vorsitzender des Aufsichtsrates: Martin Haering
>  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.opensolaris.org/pipermail/ha-clusters-discuss/attachments/20080723/5b2ddeae/attachment-0001.html