[indiana-discuss] Fwd: Code Review: PSARC/2007/688 manwhich: Deriving MANPATH from PATH

[Shawn Walker]

On Jan 9, 2008 10:25 PM, Mike Gerdts <mgerdts at gmail.com> wrote:
> I've made some enhancements to man(1), partly inspired by the default
> PATH in the October developer preview release.  Aside from updating
> the copyright year, I believe the code is ready for putback.  So far I
> have had little luck with the folks at opensolaris-code to get code
> reviews[1].  If your priorities are more aligned to have a more
> friendly man(1) in the next Indiana release, please take a look and
> get me your feedback.

http://cr.opensolaris.org/~mgerdts/manpath-from-path/usr/src/cmd/man/src/man.c.html

The comments for the various BMP flags at lines 175-177 have better
comments at lines 593-600.

In particular, the comment for BMP_FALLBACK_MANDIR at line 177 is the
same used for BMP_APPEND_DIR at 176, which seems wrong somehow.

538          * "man -p" with out operands
s/with out/without/

3191         *p = '\0';

The above seems either redundant or unnecessary given what is already
being done at lines 3166-3177.

Other than that, this looks great. The code was easy to follow, and
quite elegant in my view.

I've been following the discussions on this particular change for some
time now, and feel your are to be commended for this contributions.

I'm really looking forward to never having to set MANPATH again.

Cheers,
-- 
Shawn Walker, Software and Systems Analyst
http://binarycrusader.blogspot.com/

"To err is human -- and to blame it on a computer is even more so." -
Robert Orben