[indiana-discuss] Code review request

[Roland Mainz]

Shawn Walker wrote:
> On Jan 31, 2008 5:53 PM,  <David.Comay at sun.com> wrote:
> > http://cr.opensolaris.org/~comay/webrev-p1-1/
> >
> > This addresses for the next Live CD preview the following reported
> > issues
> >
> >         97 Prompt (PS1) should be customized
> >         205 manpath should be set to include all installed man directories
> >         339 /usr/X11/bin should be in default $PATH
> 
> It looks like these changes also cover #206:
> 
> http://defect.opensolaris.org/bz/show_bug.cgi?id=206
> 
> Correct?

Yes and no. The PATH, MANPATH and PAGER variables should be set in
either /etc/profile or ~/.profile to affect all shells and should not be
stored in ~/.bashrc (I forgot to say that in my last review comment (if
anyone is now completely confused: The seperation rules work like this:
If it should only affect the shell itself in interactive mode the
variable goes into /etc/bash.bashrc||~/.bashrc (for bash) or
/etc/ksh.kshrc||~/.kshrc (for ksh) and should not be exported into the
environment, if the setting should affect anything outside the shell the
variable goes into /etc/profile or ~/.profile and gets exported into the
environment)).

----

Bye,
Roland

-- 
  __ .  . __
 (o.\ \/ /.o) roland.mainz at nrubsig.org
  \__\/\/__/  MPEG specialist, C&&JAVA&&Sun&&Unix programmer
  /O /==\ O\  TEL +49 641 7950090
 (;O/ \/ \O;)