[iser-dev] isns client code review

[Victor Li]

Andrey,

Thanks for your review. See my comments inline:

Andrey Kuzmin wrote:
> Looks fine overall. One minor note refers to get_xid with dedicated
> xid_mutex - I believe atomic uint16_t will do the same job with less
> overhead.
>   
I will make this changes in my next putback, I am going to putback 
current code
now since Carla's testing depends on a fix for a panic in this code.
> On a separate note, sometime back we discussed the issue with one of
> multiple servers down during update. I haven't found any trace of it
> in the code. Is it supposed to be elsewhere?
>   
It is in the code. The isns client monitors registration status on each 
isns server
every 5 minutes, if one of operation was failed on a server, we are 
going to
update the registration/de-registration on that server.

See code at line 385 in isns_client.c, the old_src is the persistent 
node name
for a server if operation on that server was failed.
> On Mon, Apr 21, 2008 at 8:30 PM, Victor Li <Victor.Li at sun.com> wrote:
>   
>> I have upload the code review for isns client support to:
>>
>>  http://cr.opensolaris.org/~liv/webrev/
>>
>>  It has been tested with a Windows iSNS Server and worked fine. Since the
>>  itadm does not support isns subcommand yet, I hard-coded the isns to be
>>  enabled for testing. The basic function are ready now, the next phase is
>>  to bundle these function to itadm for enabling and disabling isns,
>>     
>
> Starting with 'itadm isns' will provide nice path to testing, so I'd
> use it as the next target.
>   
It supposed to be in my next putback in one or two weeks. Meantime, if 
you want to
try the isns client, you can change the "B_FALSE" at line 160 to "B_TRUE".

Thanks,
Victor
> Regards,
> Andrey
>
>
>
>   
>>  adding and removing target, login control isns deligation etc...
>>
>>  I prefer to putback this code before Friday, so you soon review is
>>  appreciated.
>>
>>  Thanks,
>>  Victor
>>  _______________________________________________
>>  iser-dev mailing list
>>  iser-dev at opensolaris.org
>>  http://mail.opensolaris.org/mailman/listinfo/iser-dev
>>
>>