[iser-dev] Updated code review

[Jim Moore]

David,

I just moved the line up to 209 in the new code. Once it is determined
this target already exists, the newly created one is not going on the global
list so I know I don't need the lock any more.

thanks,
-jim

David Hollister wrote:
> Jim,
>
> In iscsi_tgt.c, I'm concerned with the removal of this line:
>
>  183                 mutex_exit(&iscsit_global.global_mutex);
>
> Shouldn't that still be there?
>
> David
>
> Jim Moore wrote:
>> This is an update the webrev I posted yesterday. The main
>> difference is I added a fix for 6726163
>> The avl function needed to compare portals was not implemented and a 
>> cut/paste
>> error set up the portal compare to the wrong function.
>>
>> thanks,
>> -jim
>>
>> 6726364  system panicked when attempt to delete target
>> 6726163  system panicked when attempt to run itadm 
>> create-tpgt/list-tpgt to create/show the created tpgt
>>
>>
>> tighter checking on some failure cases
>> default portal group special case had unmatched hold/rele
>> fix memory leak of portal group tag object
>>
>> http://cr.opensolaris.org/~jdm/bugfix/
>> _______________________________________________
>> iser-dev mailing list
>> iser-dev at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/iser-dev
>>
>> _______________________________________________
>> iser-dev mailing list
>> iser-dev at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/iser-dev
>