jds SVN: spec-files

Niall Power - Sun Microsystems Ireland Niall.Power at Sun.COM
Tue Nov 14 02:02:37 PST 2006


Glynn and Stephen,

Sorry, an e-mail was sent to jds-notify but it was blocked because I was
not yet subscribed to the alias. 

Regarding the review process, I agree with you both. But in this case I
didn't have sufficient time between Erwann handing off his work on
this patch and getting it committed before build 53 as Stephen wanted.

I would welcome a review of this patch but as Stephen says this is not
a trivial patch - several thousand LOC, and is something that will take 
some time to explain in adequate detail so that people unfamiliar with
trusted stuff will be able to make sense of it.

So, I'm happy to write up a description, just give me a little time.

Cheers,
Niall.

On Tue, 2006-11-14 at 01:08 +0000, Stephen Browne wrote:
> Glynn,
> 
> I asked Niall to commit this patch so it would make the B53 respin.
> Its a port of an old patch and we haven't reviewed all the old patches
> in SVN, although we probably should :)
> 
> In saying that I do think Niall should send a mail to give people an
> opportunity to review this patch and hopefully learn something about how
> TJDS is implemented.
> 
> This particular patch is CORE to the very operation of TJDS.
> 
> Niall can you send a mail out to jds-review (not notify) and clearly
> explain each part of the patch pointing at the functional spec for TJDS.
> 
> We should probably try and get that FS doc up on open solaris somewhere.
> 
> Thanks,
> 
> Stephen.
> 
> On Mon, 2006-11-13 at 23:44, Glynn Foster wrote:
> > Hi Niall,
> > 
> > This breaks the review process - no mail was sent to jds-notify. Can you please
> > do so in future?
> > 
> > 
> > thanks,
> > 
> > Glynn
> > 
> > Niall.Power at Sun.COM wrote:
> > > Author: niall
> > > Repository: /svn/jds/spec-files
> > > Revision: 9692
> > > Branch: trunk
> > > Date: 2006-11-10 16:45:21 +0000 (Fri, 10 Nov 2006)
> > > 
> > > Modified files:
> > > 	trunk/ChangeLog
> > > 	trunk/libwnck.spec
> > > 	trunk/patches/libwnck-01-trusted-extensions.diff
> > > 
> > > Log message:
> > > 2006-11-10  Niall Power  <niall.power at sun.com>
> > > 
> > >         * libwnck.spec: reapply libwnck-01-trusted-extensions.diff
> > >         * patches/libwnck-01-trusted-extensions.diff: forward ported.
> > > 
> > > 
> > > ------------------------------------------------------------------------
> > > 
> > > U   trunk/ChangeLog
> > > U   trunk/libwnck.spec
> > > U   trunk/patches/libwnck-01-trusted-extensions.diff
> 
-- 
-------------------------------------------
 <O       Niall Power
 ( \      Sun Microsystems Ltd - Ireland
  X       Desktop Engineer. +353-1-8199097
8===D     niall.power at sun.com
-------------------------------------------



More information about the jds-notify mailing list