jds SVN: spec-files

[Jedy Wang]

On Wed, 2007-08-15 at 09:27 -0400, Laszlo (Laca) Peter wrote:
> On Wed, 2007-08-15 at 00:43 -0700, Jedy.Wang at Sun.COM wrote:
> 
> > Modified files:
> > 	trunk/ChangeLog
> > 	trunk/base-specs/evolution-data-server.spec
> > 	trunk/patches/evolution-data-server-02-endian.diff
> > 	trunk/patches/evolution-data-server-03-timezone.diff
> > 
> > Log message:
> > 2007-08-15  Wang Xin <jedy.wang at sun.com>
> > 
> >     * patches/evolution-data-server-02-endian.diff: New patch to replace
> >     the old one.
> 
> If you update a patch, please update it in bugzilla too.
This patch belongs to Damien and he told me if I commit the patch he
will update it bugzilla.
> 
> >     * patches/evolution-data-server-03-timezone.diff: New patch to replace
> >     the old one.
> 
> Does this patch match what was committed into svn.gnome.org?
This patch is different from the community one because the previous
patch for the bug has been committed into trunk but the tarball we use
is not updated. But the result should be the same.
> 
> >     * base-specs/evolution-data-server.spec: Update 02-endian.diff and
> >     03-timezone.diff.
> 
> You don't need to update the spec just for updating patches.  What you
> actually did was:
>  - autotoolized libical (for patch3)
Yes, this is a mistake. It's useless and I will remove it.
>  - changed patch2 to -p0, which is wrong: all patches are supposed
>    to be p1's
The old patch should be applied with -p1 but the new one should be
applied with -p0. And is there a patch policy implies that only -p1 is
allowed?

Regards,

Jedy
> 
> Please make sure your ChangeLog entries describe your changes.
> 
> Laca
> 
> > U   trunk/ChangeLog
> > U   trunk/base-specs/evolution-data-server.spec
> > U   trunk/patches/evolution-data-server-02-endian.diff
> > U   trunk/patches/evolution-data-server-03-timezone.diff
>