jds SVN: spec-files

[Laszlo (Laca) Peter]

On Thu, 2007-08-16 at 12:01 +0800, Jedy Wang wrote:
> > If you update a patch, please update it in bugzilla too.
> This patch belongs to Damien and he told me if I commit the patch he
> will update it bugzilla.

OK.

> > >     * patches/evolution-data-server-03-timezone.diff: New patch to replace
> > >     the old one.
> > 
> > Does this patch match what was committed into svn.gnome.org?
> This patch is different from the community one because the previous
> patch for the bug has been committed into trunk but the tarball we use
> is not updated. But the result should be the same.

That's what I meant.  So it _is_ the same, thanks.

> >  - changed patch2 to -p0, which is wrong: all patches are supposed
> >    to be p1's
> The old patch should be applied with -p1 but the new one should be
> applied with -p0. And is there a patch policy implies that only -p1 is
> allowed?

I thought it was written down somewhere, but you're right, I can't
find it.  I'll update the code review page to say that all patches
should be p1's.  This has some advantages, for example you can usually
see which tarball was used for creating the patch.

Thanks,
Laca