[jds-review] GDM patch for review

Glynn Foster Glynn.Foster at Sun.COM
Tue Oct 31 15:12:08 PST 2006



Brian Cameron wrote:
> Glynn:
> 
> Here's the updated patch (and the one I actually committed to
> spec-files).  Sorry about that.

Looks fine.

> +  g_signal_connect (GTK_TREE_VIEW (tv), "button_release_event",
> +                    G_CALLBACK (custom_list_release_event),
> +                    NULL);
> +

Minor style nit - tv doesn't need to be cast since it's does that in the
g_signal_connect function (and certainly shouldn't be cast to a GTK_TREE_VIEW).


Glynn



More information about the jds-review mailing list