[jds-review] Review : gnome-games : glchess not functional on Solaris

[Brian Cameron]

Matt:

Why don't we just fix this.  Chess is a fun game and the fix for
this problem is very easy.  Use the same code from this patch:

   http://bugzilla.gnome.org/attachment.cgi?id=54812&action=view

 From this bug:

   http://bugzilla.gnome.org/show_bug.cgi?id=321565

where I fixed the exact same problem for control-center.  Note this
patch has some nice configure.ac coding to set HAVE_FORKPTY and
HAVE_TTYCOMPAT.  And ignore the rest of the patch except for the
bits that are in "#ifdef/ifndef HAVE_FORKPTY".  I'd probably grab
the code from the latest control-center tarball rather than using
the patch in case there is newer/improved bugfixed code, but the
patch shows the files to get the code from.

If you use the same configure.ac stuff, we can probably get the
patch upstream.

Brian


> glchess is not functional on Solaris, and from what I can see this is 
> due to forkpty, missing from
> Solaris land.
> 
> As gnome-games are not supported, I've logged a bug in bugzilla, as an 
> interm solution I am removing
> glchess from our menu's so that all users don't see the option to run 
> it, very easy to add it back
> in when/if this get's resolved.
> 
> Just requires a change to gnome-games.spec (svn diff below)
> 
> bugster :  http://monaco.sfbay/detail.jsf?cr=6537569
> bugzilla : http://bugzilla.gnome.org/show_bug.cgi?id=426538
> 
> Cheers
> 
> Matt
> 
> 
> Index: base-specs/gnome-games.spec
> ===================================================================
> --- base-specs/gnome-games.spec (revision 11040)
> +++ base-specs/gnome-games.spec (working copy)
> @@ -77,8 +77,8 @@
> ## things we just don't want in the package
> rm -rf $RPM_BUILD_ROOT/var/lib/scrollkeeper
> find $RPM_BUILD_ROOT -type f -name "*.pyo" -exec rm -f {} ';'
> +rm -f $RPM_BUILD_ROOT/usr/share/applications/glchess.desktop
> 
> -
> ## install desktop files
> 
> %find_lang %{name}
> @@ -137,6 +137,9 @@
> %config %{_sysconfdir}/sound/events/*
> 
> %changelog
> +* Thu Apr 05 2007 - matt.keenan at sun.com
> +- Remove glchess.desktop, until glchess is made functional on Solaris
> +- Bugzilla : 426538
> * Wed Mar 21 2007 - damien.carbery at sun.com
> - Bump to 2.18.0.1.
> * Tue Mar 13 2007 - damien.carbery at sun.com
>