[jds-review] patch to enable battstat applet by default on laptop
Laszlo (Laca) Peter
laca at sun.com
Thu Apr 19 12:55:11 PDT 2007
Jedy,
Can you add some comment lines that explain what's happening?
Also, it's more readable if you use variables for long gconf
key names that appear multiple times, e.g.
APPLET_LIST_KEY=/apps/panel/default_setup/general/applet_id_list_jds
...
What are all the sed commands for?
Thanks,
Laca
On Thu, 2007-04-19 at 17:56 +0800, Jedy Wang wrote:
> echo '$PKG_INSTALL_ROOT/usr/bin/gconftool-2 --makefile-uninstall-rule $schemas'
> + echo 'test -c /devices/pseudo/battery at 0:battery0 && {';
> + echo ' $PKG_INSTALL_ROOT/usr/bin/gconftool-2 --direct --config-source=$GCONF_CONFIG_SOURCE --unload $SDIR/panel-default-setup-laptop.entries';
> + echo ' $PKG_INSTALL_ROOT/usr/bin/gconftool-2 --direct --config-source=$GCONF_CONFIG_SOURCE --unload $SDIR/panel-default-setup-laptop.entries /apps/panel/profiles/default';
> + echo ' APPLETS=`gconftool-2 --direct --config-source=$GCONF_CONFIG_SOURCE --owner=panel --get /apps/panel/default_setup/general/applet_id_list_jds | sed -n "s/\(\[.*\),battstat\(\]\)/\1\\2/p"`';
> + echo ' gconftool-2 --direct --config-source=$GCONF_CONFIG_SOURCE --owner=panel --unset /apps/panel/default_setup/general/applet_id_list_jds'
> + echo ' gconftool-2 --direct --config-source=$GCONF_CONFIG_SOURCE --owner=panel --type=list --list-type=string --set /apps/panel/default_setup/general/applet_id_list_jds $APPLETS'
> + echo ' APPLETS=`gconftool-2 --direct --config-source=$GCONF_CONFIG_SOURCE --owner=panel --get /apps/panel/profiles/default/general/applet_id_list_jds | sed -n "s/\(\[.*\),battstat\(\]\)/\1\\2/p"`';
> + echo ' gconftool-2 --direct --config-source=$GCONF_CONFIG_SOURCE --owner=panel --unset /apps/panel/profiles/default/general/applet_id_list_jds'
> + echo ' gconftool-2 --direct --config-source=$GCONF_CONFIG_SOURCE --owner=panel --type=list --list-type=string --set /apps/panel/profiles/default/general/applet_id_list_jds $APPLETS'
> + echo '}';
More information about the jds-review
mailing list