[kmf-discuss] code review

[Wyllys Ingersoll]

I have a preliminary code review prepared for the following bugs:

6648052 pktool(1) could allow certificate signing and verification
6652751 kmf_get_kmf_error_str() doesn't know about KMF_ERR_ATTR_NOT_FOUND
6654080 kmf_verify_data() should use algorithm from the cert if 
KMF_ALGORITHM_INDEX_ATTR is missing
6654205 kmf_find_prikey_by_cert() should be public
6654910 kmf_validate_cert() won't get over non-existent x509v3 
extensions in TA
6660235 Command summary on pktool help should be localizable.
6660622 KMF needs API to determine format of raw data

Final testing is still underway, but currently all of the existing tests 
are passing.

http://cr.opensolaris.org/~wyllys/kmf


-Wyllys