[kmf-discuss] webrev for review

[Wyllys Ingersoll]

Huie-Ying Lee wrote:
> Wyllys Ingersoll wrote:
>> I have a webrev prepared for the following fixes:
>>
>> PSARC 2008/306 pktool CLI update (dir option correction)
>> 6670712 cert of dsa type with key pair can not signcsr of rsa type, 
>> viceversa.
>> 6670714 pktool gencert keystore=nss and keytype=dsa FAIL, parameter 
>> error
>> 6670715 pktool gencsr keystore=nss and token="install" (something not 
>> "internal") core dumped
>> 6670725 keyusage would not change to new when doing signcsr which csr 
>> already have keyusage.
>> 6699535 pktool operations should not have "dir" option for file-based 
>> keystore
>> 6700175 fix for 6654080 is not complete
>>
>>
>> Please have a look and send comments:
>> http://cr.opensolaris.org/~wyllys/nv
>>
>> Thanks,
>> -Wyllys
>> _______________________________________________
>> kmf-discuss mailing list
>> kmf-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/kmf-discuss
>>   
> The changes look good to me.   I just have a couple of minor comments.
>
> 1.  libkmf/libkmf/common/certgetsetup.c:  copy_extension_data()
>
>     This function is changed to be a global function but it is still 
> private.  Should this  be a public function, say 
> kmf_copy_extension_data(), so that other applications can use it also ?

I didn't think that it would be that useful so I left it as private for now.

>
> 2. libkmf/libkmf/common/mapfile-vers
>
>    "isEqualOid" is added to this file, but I couldn't find the source 
> for this function.   Could you please tell me where it is defined ?

"IsEqualOid" is defined in certop.c , line 2852


>
> 3. pktool/list.c
>
>    There is no changes in this file.

OK, I will remove it from the list.

thanks!
  Wyllys