[ksh93-integration-discuss] pre-codereview checklist

[James Carlson]

Roland Mainz writes:
> >        I'll let the code review process deal with that.
> 
> What about this: We disable the test run in the default build but keep
> the "testshell" target around ? AFAIM that should be acceptable for
> gatekeepers as the test suite would no longer disturb the build...

A far better answer is to deliver the tests via a separate package.

Integrate the tests in ON, but do _not_ run them as part of the build
process -- deliver the tests in a package so that they can be
installed on a test system, and so that BFU automatically includes
them on all BFU'd systems.  We can then get ON-PIT to run the tests
regularly as part of the normal system test process.

Though I still think the tests don't belong in ON, the code location
is a much smaller issue than having the tests run as part of nightly
builds.

-- 
James Carlson, KISS Network                    <james.d.carlson at sun.com>
Sun Microsystems / 1 Network Drive         71.232W   Vox +1 781 442 2084
MS UBUR02-212 / Burlington MA 01803-2757   42.496N   Fax +1 781 442 1677