"findunref"'s exception_list and deleted files... / was: Re: [ksh93-integration-discuss]Re:[osol-code]Roundtwo:((pre-)pre-review)ksh93-integrationwebrev2007-02-02

[Peter Memishian]

 > I've filed and fixed this issue with
 > http://bugs.grommit.com/show_bug.cgi?id=204 ("RFE: Update the findunref
 > exception_list per pre-pre-review comments and provide a list of
 > upstream files which should be deleted from the codebase.") today.

Looks good, thanks!

 > Notes:
 > 1. "exception_list" got three additional members for the
 > ast-ksh.2007-03-28 update:
 > -- snip --
 > ./lib/libcmd/common/cksum.c
 > ./lib/libcmd/common/md5sum.c
 > ./lib/libcmd/common/sum.c
 > -- snip --
 > Right now we can't use these builtins because they depend on libsum.so.1
 > (e.g. sum(1) wrapped in alternate library with the option to run other
 > algorithms (MD5, SHA1, etc.)) which isn't ARC'ed yet.

Umm, OK.  (I presume libsum is also not part of your putback.)

 > 2. usr/src/lib/libshell/misc/filelist.txt tracks the files which are
 > going to be deleted, either before the putback or (maybe better) do the
 > putback in one piece and make a 2nd commit to remove the files listed in
 > usr/src/lib/libshell/misc/filelist.txt to make sure they show up in
 > deleted_files/ ... that would have the advantage that people who are
 > looking for those files can find them in the trashcan...
 > ... would that be usefull ?

There's no precedent for doing that, nor do I think it's all that useful
given that deleted_files gets purged at the end of each release train.

--
meem