[ksh93-integration-discuss] Re: [osol-code] Round two: ((pre-)pre-review) ksh93-integrationwebrev2007-02-02

[Roland Mainz]

Peter Memishian wrote:
> 
>  > > usr/src/lib/libast/mapfile-vers
>  > >
>  > >         Lines 29-618 - Please just include the results and don't embed
>  > >         the script inside the comment.
>  >
>  > Fixed (I wish we could keep the comments to document how this stuff was
>  > created... ;-( ).
> 
> They can go in the CR used to integrate the feature.  Actually, they can
> go pretty much anywhere *except* the source tree.

There is still the unanswered/unsolved problem to track such things...
any CR documentation is AFAIK not public and (more important) not
maintained by a SCM (and even if there is such a SCM it would need to be
kept in sync with the main OS/Net SCM, following all branches, splits,
mergers etc.).

>  > > usr/src/lib/libdll/common/Makefile
>  > >
>  > >         Is this really the Makefile you intend to putback?  It looks
>  > >         like it came from the ksh93 source itself.
>  >
>  > Yes, see above (no fork() of AST codebase, please).
> 
> Please, no alien Makefiles.  They've invaded our source tree in the past
> (e.g., the old SNMP codebase), and they were an unbelievable headache.
> The Makefiles in our tree need to be written for our build system.

The Makefile isn't used, it's just there (well, until now it didn't bite
anyone). The problem I see is that if we remove this file we create a
"precedent" for more file stripping in our copy of the AST codebase.
Where should we start - and where should we stop ? How do we keep track
of removed files and updates to them (in theory the *.diff files could
be used to track&&restore removed files but exactly this mechanism
doesn't seem to be welcome in the OS/Net tree... ;-( ) ? We can't really
affort trying to rip out source files "randomly" since this would break
any (semi-)automated update process and doing such stuff manually would
be time-consuming and error-prone.

----

Bye,
Roland

-- 
  __ .  . __
 (o.\ \/ /.o) roland.mainz at nrubsig.org
  \__\/\/__/  MPEG specialist, C&&JAVA&&Sun&&Unix programmer
  /O /==\ O\  TEL +49 641 7950090
 (;O/ \/ \O;)