[ksh93-integration-discuss] final ksh93 integration code review

[April Chin]

Below are the webrev links for the final code review for the ksh93 
integration project (for this initial integration).  It includes incremental
webrevs showing diffs since the last-posted code review round.

Note that these webrevs are based on workspaces which have been sync'd
with the ON clone gate as of June 27th, so there are differences here
from what you see on
http://svn.genunix.org/repos/on/branches/ksh93/gisburn/prototype005/,
which is based on build 61.

I have included in the "To:" line a list of potential code reviewers,
but of course this is an open code review, so please let Roland 
(roland.mainz at nrubsig.org) and me know if you would like to participate in the
code review.

I'll send a separate email to internal Sun reviewers pointing to the webrev 
for the single Makefile changed in the closed source.

We'd like to get code review comments by the end of next week, July 13th, if 
possible. There is a US holiday this week (July 4) which will affect some 
reviewers' availability.

Thanks in advance for your help!

The base directory for code reviews is at:
	http://cr.grommit.com/~chin/ksh93-webrev-jun29

FULL WEBREVS

All files:
http://cr.grommit.com/~chin/ksh93-webrev-jun29/jun29-allfiles/

Makefiles:
http://cr.grommit.com/~chin/ksh93-webrev-jun29/jun29-makefiles/

Non-AST files:
http://cr.grommit.com/~chin/ksh93-webrev-jun29/jun29-nonattfiles/

AST files:
http://cr.grommit.com/~chin/ksh93-webrev-jun29/jun29-attfiles/

INCREMENTAL WEBREVS
Current code vs. the codereview sent out June 6th  (pre-review round three):

All files:
http://cr.grommit.com/~chin/ksh93-webrev-jun29/jun06vjun29-allfiles/

Makefiles:
http://cr.grommit.com/~chin/ksh93-webrev-jun29/jun06vjun29-makefiles/

non-AST files:
http://cr.grommit.com/~chin/ksh93-webrev-jun29/jun06vjun29-nonattfiles/

AST files:
http://cr.grommit.com/~chin/ksh93-webrev-jun29/jun06vjun29-attfiles/

NOTES

Same notes as listed in the previous round code review announcement
	https://www.opensolaris.org/jive/thread.jspa?threadID=32411&tstart=0

plus these additional changes:

1. Removed old hack to conftab.c; affects getconf SSIZE_MAX 
	http://bugs.grommit.com/show_bug.cgi?id=263

2. Implement changes based on David Comay's code review comments
	http://bugs.grommit.com/show_bug.cgi?id=266

3. Changes to usr/src/tools/scripts/bfu.sh needed for /etc/ksh.kshrc
	http://bugs.grommit.com/show_bug.cgi?id=273

4. Remove xpagesize_*-options from ksh build
  	http://bugs.grommit.com/show_bug.cgi?id=275
  	
5. More changes to usr/src/lib/libcmd/common/date.c to avoid sccs expansion
  	http://bugs.grommit.com/show_bug.cgi?id=284

Thanks,
	April