[ksh93-integration-discuss] final ksh93 integration code review

Peter Memishian peter.memishian at Sun.COM
Sat Jul 7 22:27:00 PDT 2007


 > Or maybe I should stop worrying... :-)
 > ...I've added the "Makefile.ast" thing and attached the new patch as
 > "ksh93_integration_review_meem003.diff.txt" ...

Great :-) 

 > +# Set common AST flags including C99/XPG6 mode (which is needed to
 > +# support the math stuff in the AST tools and make them fully
 > +# POSIX conformant).
 > +include ../../../Makefile.ast

I'd rather we didn't talk about the details of what Makefile.ast did, so
that we don't have to update all of the things that include it every time
we change Makefile.ast (which would kinda defeat the purpose ;-)  So how
about something like:

  # Set common AST build flags (e.g., needed to support the math stuff).
  include ../../../Makefile.ast

The point isn't to choose my wording, but to keep it general so that we
don't have to update it too much.

--
meem


More information about the ksh93-integration-discuss mailing list