[ksh93-integration-discuss] final ksh93 code review, round two (July 9)

[Roland Mainz]

April Chin wrote:
> > James Carlson wrote:
> > >   - No changes were made to these files:
> > >         $SRC/lib/libcmd/amd64/Makefile
> > >         $SRC/lib/libcmd/i386/Makefile
> > >         $SRC/lib/libcmd/sparc/Makefile
> > >         $SRC/lib/libcmd/sparcv9/Makefile
> > >     Don't deliver unchanged files.
> >
> > What do you mean ?
> 
> Since the added line
>         SHELL=/usr/bin/ksh
> was removed from these Makefiles and moved to
> usr/src/lib/libcmd/Makefile.com, the only changes left are to the comments
> (updated CDDL, copyright).  So we should no longer be touching these files.

Why ? At least the "CDDL/copyright update job" would be done (e.g. it
would save the work when someone crawls over the tree and does a general
CDDL license template update) ...

> > >   - $SRC/pkgdefs/Makefile: looks like a missed merge.  (Not a code
> > >     review issue, but you'll want to clean it up before going for
> > >     RTI.)
> >
> > Erm... what do you mean ?
> 
> This is something I need to do (merge again from the Nevada gate) on my end.

Ok...

----

Bye,
Roland

-- 
  __ .  . __
 (o.\ \/ /.o) roland.mainz at nrubsig.org
  \__\/\/__/  MPEG specialist, C&&JAVA&&Sun&&Unix programmer
  /O /==\ O\  TEL +49 641 7950090
 (;O/ \/ \O;)