[ksh93-integration-discuss] final ksh93 code review, round three

April Chin April.Chin at sun.com
Fri Jul 13 16:56:22 PDT 2007


Below are the locations of the new webrev with Roland's latest changes, based
on review comments from round two of the final code review (July 9th version).

The base directory for the latest code review is:
	http://cr.grommit.com/~chin/ksh93-webrev-jul13

FULL WEBREVS

All files:
http://cr.grommit.com/~chin/ksh93-webrev-jul13/jul13-allfiles

Makefiles:
http://cr.grommit.com/~chin/ksh93-webrev-jul13/jul13-makefiles

Non-AST files:
http://cr.grommit.com/~chin/ksh93-webrev-jul13/jul13-nonattfiles

AST files:
http://cr.grommit.com/~chin/ksh93-webrev-jul13/jul13-attfiles

INCREMENTAL WEBREVS
Current code (round three) vs. the codereview sent out July 11th (final review
round two, labelled July 9).  Note that all three sets of incremental webrevs
are identical.

All files:
http://cr.grommit.com/~chin/ksh93-webrev-jul13/jul9vjul13-allfiles

Makefiles:
http://cr.grommit.com/~chin/ksh93-webrev-jul13/jul9vjul13-makefiles

non-AST files:
http://cr.grommit.com/~chin/ksh93-webrev-jul13/jul9vjul13-nonattfiles


NOTES

Same notes as listed in the pre-reviews:
	https://www.opensolaris.org/jive/thread.jspa?threadID=32411&tstart=0

and previous rounds of final code review:
	http://www.opensolaris.org/jive/thread.jspa?threadID=34912&tstart=0

Plus this additional fix for round 3:

	RFE: Update ksh93-integration tree per second round of 
	Peter Memishian's review comments
	http://bugs.grommit.com/show_bug.cgi?id=296
	
The files usr/src/lib/libcmd/{amd64,i386,sparc,sparcv9}/Makefile
show up in the incremental webrevs only; they revert back to the 
version in the Nevada gate and will no longer be part of the 
delivery for this project.  

Also, usr/src/lib/Makefile.astinclude has been renamed to 
usr/src/lib/Makefile.asthdr

Thanks,
	April




More information about the ksh93-integration-discuss mailing list