[Fwd: [ksh93-integration-discuss] ksh93-integrationpre-reviewround"two" (webrev 2007-05-14)]

[Peter Memishian]

Roland, here are a few more comments for you.  Sorry for the gradual input.

General:

	* There's no such thing as ROOTLINT64.  Please make sure it gets
	  removed from any Makefiles (e.g. libshell/amd64/Makefile).

	* Seems like Makefile.astinclude and Makefile.libastl10n belong in
	  usr/src/lib, since they're used by more than libast.  (And maybe
	  Makefile.libastl10n should be renamed to Makefile.astmsg?)

cmd/ast/Makefile

	* 40-42: Who uses the `check', `_msg', and `_dc' targets here?

cmd/ast/msgcc/Makefile:

	* 38: Reaching around into libpp/common is not recommended (e.g.,
	  it breaks sparse workspaces).  Please have libpp install what
	  you need into the proto area.

	* 58-61: Seems simpler as:

	  LDLIBS += -last
	  msgcpp: LDLIBS += -lpp

	* 73-78: Seems like this ROOTAST* business could just be replaced
	  with `ROOTCMDDIR=$(ROOT)/usr/ast/bin'

	* 81: Change `ASTPROG=' to `PROG='.  Then change `$(ASTPROG)' to
	  `$(PROG)' on line 83 and $(ROOTASTPROG) to $(ROOTCMD) on line 84

	* 91-98: With above changes, these lines can be removed.

lib/libshell/Makefile:

	* 44-46: Merge these lines.

lib/libshell/Makefile:

	* 93: What uses $(MOBJS)?

lib/libshell/Makefile.demo:

	* Seems like the ROOTDEMO* logic is generic, and should be folded
	  into lib/Makefile.lib.
--
meem