[Fwd:[ksh93-integration-discuss]ksh93-integrationpre-reviewround"two"(webrev2007-05-14)]

[Roland Mainz]

Peter Memishian wrote:
> 
>  > > If it needed to use the Makefile.ast* logic, it would live under lib/ast.
>  > > Otherwise, it wouldn't.
>  >
>  > Uhm... IMHO that's wrong. Subdirs should be project-specific (if there
>  > is a strong need (and good justification) for such a thing (which I
>  > don't see for libshell&co. - remeber both AST and Solaris's base code
>  > (System V) share the same origin)) and not based on the underlying APIs
>  > used by the code.
> 
> I don't quite understand what you're getting at.  If several libraries
> share requirements for things such as the way lint should be handled or
> the way internationalization should be done, then organizing the source
> tree such that those requirements can be implemented by common Makefiles
> seems reasonable to me.

Well, right now the "shared" parts are only stored in two Makefile
fragments (e.g. usr/src/lib/Makefile.astmsg and
usr/src/lib/Makefile.astinclude) and IMO two files do not justify a
seperate subdir. The part where my stomach started cooking-up something
horrible (add some elektrodes (Pb+PbO2) and you could power a small
laptop from that stuff) was the idea to move the whole AST sources into
such a subdir, too (and I guess the creation of usr/src/lib/ast/ would
trigger exactly this idea... (and I really don't like that one...)).

> But I also don't see this as a big deal.  Having the Makefiles in lib/
> directly seems OK.

Ok... thanks! :-)

>  > >  > and ROOTDEMODIRBASE depends on the demo source sitting in
>  > >  > "common/".
>  > >
>  > > Could it use $(SRCDIR) directly (and then one could conditionally override
>  > > $(SRCDIR) for $(ROOTDEMOFILES) if necessary?)
>  >
>  > SRCDIR is not set in this level. We're talking about
>  > usr/src/lib/lib*/Makefile, not usr/src/lib/lib*/$(TRANSMACH)/Makefile
> 
> I'm confused why that is.  Why lib*/Makefile rather than lib*/Makefile.com?

The lib*/Makefile.com makefile fragement is included by
lib*/$(TRANSMACH)/Makefile to run the MACH-specific stuff - but all the
demo code is MACH/ISA-independent (e.g. /usr/demo/ksh/ only contains
scripts and (later) sample data (e.g. MusicML)) and therefore handled by
lib*/Makefile.

----

Bye,
Roland

-- 
  __ .  . __
 (o.\ \/ /.o) roland.mainz at nrubsig.org
  \__\/\/__/  MPEG specialist, C&&JAVA&&Sun&&Unix programmer
  /O /==\ O\  TEL +49 641 7950090
 (;O/ \/ \O;)