[ksh93-integration-discuss] Re: [osol-code] ksh93-integration pre-review round "three" (webrev 2007-06-06)

[David.Comay at Sun.COM]

Roland,

> * Webrev over all non-AST files (this includes the files in
> usr/src/cmd/ast/msgcc/ by accident):
> http://www.nrubsig.org/people/gisburn/work/solaris/ksh93_integration/ksh93_integration_prototype005_webrev_20070606/non_ast_files/webrev/

Here are my comments for round "three":

usr/src/cmd/ksh/Makefile.com

 	Lines 101-109 - As I indicated in an earlier review, I don't
 	believe this is necessary.  Both Nevada and the Solaris 10
 	patch gate do large pages automatically (or so-called out of
 	the box) and so including these options is unnecessary.
 	However, I've cc'ed Bart Smaalders who is an expert in this
 	area who can suggest whether or not it makes sense to include
 	this.

usr/src/lib/libc/port/regex/wordexp.c

 	Lines 70, 80, 331-332, 343-344, 384-385, 404-405, various other
 	lines in wordexp() - It appears there's some sort of mismerge
 	with Roger's

 		PSARC 2006/659 fork extensions
 		6497356 fork extensions

 	which came into snv_56.  At the very least, there's a lot more
 	change here than the last time I reviewed this file and some of
 	the changes seem to be a regression.

usr/src/lib/libshell/misc/buildksh93.ksh

 	If we're going to putback this file, then I would suggest the
 	following changes:

 	Line 169 - Instead of "Roland or April", I would provide a
 	pointer to the OpenSolaris project page

 		http://opensolaris.org/os/project/ksh93-integration/

 	as individuals come and go, but the project should live on.

 	Line 170 - s/weired/weird/

 	Lines 195-197 and 214 - See my above comments for
 	usr/src/cmd/ksh/Makefile.com concerning large pages.

usr/src/pkgdefs/SUNWarc/prototype_com
usr/src/pkgdefs/SUNWarc/prototype_i386
usr/src/pkgdefs/SUNWarc/prototype_sparc

 	I know what's happened to libcmd as part of this project but
 	why are you no longer delivering the lint libraries via these
 	three files (especially since you're updating llib-lcmd
 	itself?)

usr/src/pkgdefs/SUNWastdev/prototype_com

 	Lines 46-57 - Please sort the list by pathname (column 3).

usr/src/pkgdefs/SUNWcsl/prototype_com

 	Line 77 - Could you please move this entry after the "libaio"
 	one to maintain the sorted order?

usr/src/pkgdefs/SUNWcsl/prototype_i386

 	Line 228 - Could you please move this entry after the "libaio"
 	one to maintain the sorted order?

usr/src/pkgdefs/SUNWcsl/prototype_sparc

 	Line 217 - Could you please move this entry after the "libaio"
 	one to maintain the sorted order?

usr/src/tools/findunref/exception_list

 	Within each block, could you please sort the pathnames?

dsc