[ksh93-integration-discuss] Re: [osol-code]Roundtwo:((pre-)pre-review)ksh93-integrationwebrev2007-02-02

[Glenn Fowler]

On Mon, 12 Mar 2007 13:52:26 +0800 Peter Memishian wrote:
>  > > Taking dirstd.h as an example, it says:
>  > > 
>  > >   23 /*
>  > >   24  * AT&T Bell Laboratories
>  > >   25  *
>  > >   26  * <dirent.h> for systems with no opendir()
>  > >   27  */
>  > > 
>  > > It's impossible that opendir() will disappear from Solaris, so this file
>  > > will never be useful.  How can it be argued that this "may" be used in
>  > > future work?
>  > 
>  > The the matching codepath is AFAIK used for FS3D support, too. From
>  > "usr/src/lib/libast/common/dir/dirlib.h":

> Hmm, I don't know much about FS3D, but I find it highly unlikely that
> proper Solaris support for it would involve interposing on the libc *dir()
> routines.  Instead, I'd expect that we'd build support into the *dir()
> routines themselves.  In other words, architecturally, this doesn't seem
> like a direction we'd ever pursue with Solaris.  At the same time, this is
> a tiny file and I don't think it's worth complicating future merges for
> the sake of its removal.

3d fs intercepts are done in the independent 3d library
the (ancient) libast dir workaround files are used to build lib3d
but are only active on systems with no or non-posix readdir
(just like for libast)

> As an aside: it seems like the comment atop dirstd.h is wrong and needs to
> be corrected in the upstream source.

we have not edited source headers just to match the most recent
	{ merge buyout name-change }
that could be a full time job
besides, roland didn't show the 21 line copyright header that is prepended
during source packaging -- those headers are consistent and up to date at
the time of packaging

its current incarnation is (modulo source comment style):
/***********************************************************************
*                                                                      *
*               This software is part of the ast package               *
*           Copyright (c) 1985-2007 AT&T Knowledge Ventures            *
*                      and is licensed under the                       *
*                  Common Public License, Version 1.0                  *
*                      by AT&T Knowledge Ventures                      *
*                                                                      *
*                A copy of the License is available at                 *
*            http://www.opensource.org/licenses/cpl1.0.txt             *
*         (with md5 checksum 059e8cd6165cb4c31e351f2b69388fd9)         *
*                                                                      *
*              Information and Software Systems Research               *
*                            AT&T Research                             *
*                           Florham Park NJ                            *
*                                                                      *
*                 Glenn Fowler <gsf at research.att.com>                  *
*                  David Korn <dgk at research.att.com>                   *
*                   Phong Vo <kpv at research.att.com>                    *
*                                                                      *
***********************************************************************/

-- Glenn Fowler -- AT&T Research, Florham Park NJ --