2008/352 IS-IS For OpenSolaris

[James Carlson]

Nicolas Williams writes:
> On Mon, Jun 02, 2008 at 10:01:28AM -0400, James Carlson wrote:
> > I don't think it would.  We'd end up with multiple versions of that
> > library delivered (one through quagga.net and the other through ON),
> > and all the problems that causes.  We'd be hard-pressed to keep the
> > forked sources in sync, and make sure the right thing happens on each
> > platform.
> 
> That's not what I meant.  The libdlpi contributed to Quagga would get
> built only when it doesn't exist on the build (target) system.  Thus
> there wouldn't be two versions of libdlpi being delivered on any version
> of Solaris.

I don't think that works too well.  Consider what happens when some
open source repository (such as blastwave or similar) compiles Quagga
on Solaris 8: they're building packages intended to run on that
version of Solaris *and* all newer ones.

> > All of the DLPI code in Quagga, including the special code for
> > filtering out ISO packets and glue into the Quagga data structures,
> > amounts to 600 lines of code and comments.  And other than (perhaps)
> > the debatable path issue, it's all based on stable interfaces.
> 
> See, I'd no idea.  I was expecting much worse and hoping that you could
> improve the DLPI code in Quagga by using libdlpi and contributing a copy
> so that Quagga can build on versions of Solaris that lack libdlpi (see
> above).

If there were a stable libdlpi on all the versions of Solaris on which
Quagga delivers, we'd very likely use it.  It probably wouldn't reduce
the complexity very much -- the filtering and Quagga bits would still
need to be there; just the simple DLPI parts would need to be replaced
by libdlpi calls -- but it'd be desirable for maintenance anyway.

I think it's a "could be a future RFE" type of suggestion.

-- 
James Carlson, Solaris Networking              <james.d.carlson at sun.com>
Sun Microsystems / 35 Network Drive        71.232W   Vox +1 781 442 2084
MS UBUR02-212 / Burlington MA 01803-2757   42.496N   Fax +1 781 442 1677