2008/688 Sun Cluster TCP/IP Hooks Update

[Erik Nordmark]

Huafeng Lu wrote:

>> I don't understand why a new udp_cl_v6lastdst is needed since udp 
>> already has a udp_v6lastdst field.
> 
> The udp_v6lastdst field is used for Trusted Extension. To be safe, I 
> don't want to reuse it, so the two new fields are introduced.

That approach leads to exponentially increasing complexity over time.

If you understand udp.c then you should be able to convince yourself 
that your use of udp_v6lastdst doesn't interfere with its use in TX.
If you don't understand udp.c sufficiently well to do that, then it 
might be that you shouldn't touch udp.c in the first place.

Sorry to be so hard-nosed, but I'm trying to dig ourselves out of 15+ 
years of this attitude of changing code without fully understanding it 
which has resulted in a bit of a mess.

    Erik