PSARC 2009/137 Bandwidth Limit for Virtual Interface

James Carlson james.d.carlson at sun.com
Wed Feb 25 07:15:40 PST 2009


Cecilia Hu writes:
> So, before, a virt-install command line can look like:
> #virt-install ...--mac a:b:c:d:e:f --bridge bge0 --rate 100M/s \
>                   --mac g:h:i:j:k:l --bridge bge1 --rate 200M/s...
> Now, it looks like:
> #virt-install ...--network mac=a:b:c:d:e:f,bridge=bge0,rate=100M/s \
>                   --network mac=g:h:i:j:k:l,bridge=bge1,rate=200M/s...

This seems a bit odd to me.  If I read this correctly, the underlying
problem is that the current parameters have positional significance,
and this makes them harder to understand as a grouping.  (In other
words, you have to specify "--mac" first, and then can specify
"--bridge" after.)

But why add "--rate" to the mess?  The existing command line doesn't
support rate, and it seems that you're trying to mark the old usage as
"Obsolete," so why not just drop "--rate" and force anyone who wants
to set the bandwidth limit to use the new command format?

> | Interface			| Stability	| Comments            |

Missing from this table is:

  -m,--mac,-b,--bridge		Obsolete Uncommitted	Old-style options

> | new -w/--network syntax and	|		|                     |
> | 'rate' property of		|		|                     |
> | virt-install(1M)		| volatile	|                     |

"Volatile" means that scripts can't safely use this new option.  Is
that intended?

> | "networkresource" and "rate" 	|		|                     |
> | elements in XML		|		|                     |
> | configuration file		| Uncommitted	|                     |

Why do users mess with the XML file?  That's what "Uncommitted"
implies.  I would have expected "Committed Private" instead.

-- 
James Carlson, Solaris Networking              <james.d.carlson at sun.com>
Sun Microsystems / 35 Network Drive        71.232W   Vox +1 781 442 2084
MS UBUR02-212 / Burlington MA 01803-2757   42.496N   Fax +1 781 442 1677



More information about the opensolaris-arc mailing list