Issues for LSARC/2008/598: Sun Scalable Visualization

[Alan Coopersmith]

> The CSW* packages come from blastwave.org

blastwave.org or opencsw.org?   (The CSW project recently forked into two
separate projects.)

> CSWexpect
> CSWtcl
> CSWtk

Why are you using these instead of the versions already included in
Solaris / OpenSolaris?

> SUNWreadline

I don't see this in your Solaris_package_files.txt - are you shipping this
in /usr/lib with headers in /usr/include?   Are you warning users at all that
any software they build that calls this may become subject to the GPL?

>  8.1.1 For Solaris components, what Solaris release(s) does it run on
>        or work with?
> OpenSolaris 2008.11

Really?  Not on Solaris 10 or earlier at all?
How do you support SPARC then?   Why do you modify dtlogin configuration,
which doesn't exist on Linux or OpenSolaris?

> * changes the default $PATH and $LD_LIBRARY_PATH for all users

How does it change the default $PATH?
How does it set $LD_LIBRARY_PATH without breaking other software?

Suggested TCR: If it is absolutely impossible to avoid setting
 LD_LIBRARY_PATH, LD_LIBRARY_PATH_32 & LD_LIBRARY_PATH_64 must
 be used to avoid breaking 32 vs. 64 bit applications.

> cr_start.sh           name & arguments   Committed        Scalable Viz User's Guide
> dmx_start.sh          name & arguments   Committed        Scalable Viz User's Guide
> paraview.sh           name & arguments   Committed        Paraview docs
> gui_start.sh          name & arguments   Committed        Scalable Viz User's Guide

Why do your command names all end in *.sh?   Will you rename them if in future
versions they change from shell scripts to perl, python or C code?

What shell is used for these scripts?   If it's /bin/sh, have you verified they
work with both classic Solaris /bin/sh and ksh93 (which OpenSolaris uses as
/bin/sh)?

> We edit:
>  * /etc/dt/config/Xconfig to set Dtlogin*grabServer: False

As much as it pains me to say it, given the security-reducing change you make:
TCR: Perform equivalent modifications to gdm configuration as made to dtlogin
     configuration.   (gdm is used on OpenSolaris as dtlogin is removed, and
     gdm may be used on Solaris 10 if accessibility is required or the site
     admin otherwise prefers it.)

> ./SUNWdmx/reloc/dmx/include/X11/*
> ./SUNWdmx/reloc/dmx/lib/X11/*

You appear to be shipping a large portion of the X Window System, including
many libraries and headers which would already be present on the system, and
which if included in the global LD_LIBRARY_PATH you set would break other
applications.

TCR: Stop that!

-- 
	-Alan Coopersmith-           alan.coopersmith at sun.com
	 Sun Microsystems, Inc. - X Window System Engineering